LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Steve Wise <swise@opengridcomputing.com>
Cc: divy@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] cxgb3 - FW version update
Date: Sun, 25 Feb 2007 14:48:32 -0500	[thread overview]
Message-ID: <45E1E810.2000706@garzik.org> (raw)
In-Reply-To: <1172431719.4717.8.camel@stevo-laptop>

Steve Wise wrote:
> Hey Divy,
> 
> You missed a printk change.  Here is an updated patch.
> 
> ------------
> 
> Update FW version to 3.2
> 
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> ---
> 
>  drivers/net/cxgb3/t3_hw.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c
> index 365a7f5..08a6295 100644
> --- a/drivers/net/cxgb3/t3_hw.c
> +++ b/drivers/net/cxgb3/t3_hw.c
> @@ -884,11 +884,11 @@ int t3_check_fw_version(struct adapter *
>  	major = G_FW_VERSION_MAJOR(vers);
>  	minor = G_FW_VERSION_MINOR(vers);
>  
> -	if (type == FW_VERSION_T3 && major == 3 && minor == 1)
> +	if (type == FW_VERSION_T3 && major == 3 && minor == 2)
>  		return 0;
>  
>  	CH_ERR(adapter, "found wrong FW version(%u.%u), "
> -	       "driver needs version 3.1\n", major, minor);
> +	       "driver needs version 3.2\n", major, minor);

I would rather fix the code to use constants, and thus avoid this 
problem ever happening again.

	Jeff




  reply	other threads:[~2007-02-25 19:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-25  0:44 divy
2007-02-25 19:28 ` Steve Wise
2007-02-25 19:48   ` Jeff Garzik [this message]
2007-02-25 21:59     ` Steve Wise
2007-02-25 22:39       ` Jeff Garzik
2007-02-26  0:36         ` Divy Le Ray
  -- strict thread matches above, loose matches on Subject: below --
2007-02-26  0:32 divy
2007-02-22 11:59 divy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45E1E810.2000706@garzik.org \
    --to=jeff@garzik.org \
    --cc=divy@chelsio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    --subject='Re: [PATCH 3/7] cxgb3 - FW version update' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).