LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data
Date: Fri, 02 Mar 2007 20:17:32 -0500 [thread overview]
Message-ID: <45E8CCAC.7040304@garzik.org> (raw)
In-Reply-To: <20070301233324.GA20193@xyzzy.farnsworth.org>
Dale Farnsworth wrote:
> We were using the platform_device.id field to identify which ethernet
> port is used for mv643xx_eth device. This is not generally correct.
> It will be incorrect, for example, if a hardware platform uses a single
> port but not the first port. Here, we add an explicit port_number field
> to struct mv643xx_eth_platform_data.
>
> This makes the mv643xx_eth_platform_data structure required, but that
> isn't an issue since all users currently provide it already.
>
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
>
> ---
>
> arch/mips/momentum/jaguar_atx/platform.c | 8 ++
> arch/mips/momentum/ocelot_3/platform.c | 8 ++
> arch/mips/momentum/ocelot_c/platform.c | 4 +
> arch/powerpc/platforms/chrp/pegasos_eth.c | 2
> arch/ppc/syslib/mv64x60.c | 12 +++-
> drivers/net/mv643xx_eth.c | 59 ++++++++++----------
> include/linux/mv643xx.h | 1
> 7 files changed, 62 insertions(+), 32 deletions(-)
ACK but not applied, patch corrupted
next prev parent reply other threads:[~2007-03-03 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 23:31 [PATCH 1/2] mv643xx_eth: move mac_addr inside mv643xx_eth_platform_data Dale Farnsworth
2007-03-01 23:33 ` [PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data Dale Farnsworth
2007-03-03 1:17 ` Jeff Garzik [this message]
2007-03-03 1:17 ` [PATCH 1/2] mv643xx_eth: move mac_addr inside mv643xx_eth_platform_data Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-02-28 22:40 [PATCH 1/2] mv643xx_eth: move mac_addr inside of mv643xx_eth_platform_data Dale Farnsworth
2007-02-28 22:47 ` [PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data Dale Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E8CCAC.7040304@garzik.org \
--to=jeff@garzik.org \
--cc=dale@farnsworth.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).