LKML Archive on
help / color / mirror / Atom feed
From: Andres Salomon <>
To: Andrew Morton <>
Cc: Ingo Molnar <>, Thomas Gleixner <>,
Subject: [PATCH] highres: warn on softirq handling an unsafe callback
Date: Mon, 05 Mar 2007 05:02:07 -0500	[thread overview]
Message-ID: <> (raw)

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

run_hrtimer_queue is called from a softirq context, and should never run
a callback that is classified as HRTIMER_CB_IRQSAFE_NO_SOFTIRQ.  A bug
in unrelated code had managed to trigger that bug, so let's add an
explicit warning to this function.

Signed-off-by: Andres Salomon <>

[-- Attachment #2: hrtimer5.patch --]
[-- Type: text/x-patch, Size: 482 bytes --]

diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h
diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
index 476cb0c..167c296 100644
--- a/kernel/hrtimer.c
+++ b/kernel/hrtimer.c
@@ -1130,6 +1130,7 @@ static inline void run_hrtimer_queue(struct hrtimer_cpu_base *cpu_base,
 		if (base->softirq_time.tv64 <= timer->expires.tv64)
 		fn = timer->function;

             reply	other threads:[~2007-03-05 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05 10:02 Andres Salomon [this message]
2007-03-05 10:07 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] highres: warn on softirq handling an unsafe callback' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).