[PATCH] x86_64: shut up vm86(2)

[PATCH] x86_64: shut up vm86(2)

[Alexey Dobriyan]

>From originally rate-limited printk, to just printk, to current version.
Everybody had enough time to learn about vm86(2) absense.
Also remove possibility of dmesg spamming.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 arch/x86_64/ia32/ia32entry.S |    4 ++--
 arch/x86_64/ia32/sys_ia32.c  |   12 ------------
 2 files changed, 2 insertions(+), 14 deletions(-)

--- a/arch/x86_64/ia32/ia32entry.S
+++ b/arch/x86_64/ia32/ia32entry.S
@@ -512,7 +512,7 @@ #endif
 	.quad stub32_iopl		/* 110 */
 	.quad sys_vhangup
 	.quad quiet_ni_syscall	/* old "idle" system call */
-	.quad sys32_vm86_warning	/* vm86old */ 
+	.quad quiet_ni_syscall	/* vm86old */ 
 	.quad compat_sys_wait4
 	.quad sys_swapoff		/* 115 */
 	.quad compat_sys_sysinfo
@@ -565,7 +565,7 @@ #endif
 	.quad sys_mremap
 	.quad sys_setresuid16
 	.quad sys_getresuid16	/* 165 */
-	.quad sys32_vm86_warning	/* vm86 */ 
+	.quad quiet_ni_syscall	/* vm86 */ 
 	.quad quiet_ni_syscall	/* query_module */
 	.quad sys_poll
 	.quad compat_sys_nfsservctl
--- a/arch/x86_64/ia32/sys_ia32.c
+++ b/arch/x86_64/ia32/sys_ia32.c
@@ -842,18 +842,6 @@ long sys32_fadvise64_64(int fd, __u32 of
 			       advice); 
 } 
 
-long sys32_vm86_warning(void)
-{ 
-	struct task_struct *me = current;
-	static char lastcomm[sizeof(me->comm)];
-	if (strncmp(lastcomm, me->comm, sizeof(lastcomm))) {
-		compat_printk(KERN_INFO "%s: vm86 mode not supported on 64 bit kernel\n",
-		       me->comm);
-		strncpy(lastcomm, me->comm, sizeof(lastcomm));
-	} 
-	return -ENOSYS;
-} 
-
 long sys32_lookup_dcookie(u32 addr_low, u32 addr_high,
 			  char __user * buf, size_t len)
 {

Re: [PATCH] x86_64: shut up vm86(2)

[Andi Kleen]

On Thu, Mar 01, 2007 at 12:40:46AM +0300, Alexey Dobriyan wrote:
> From originally rate-limited printk, to just printk, to current version.
> Everybody had enough time to learn about vm86(2) absense.

I don't think that's true. I prefer to keep the message.

-Andi

Re: [PATCH] x86_64: shut up vm86(2)

[Chuck Ebbert]

Andi Kleen wrote:
> On Thu, Mar 01, 2007 at 12:40:46AM +0300, Alexey Dobriyan wrote:
>> From originally rate-limited printk, to just printk, to current version.
>> Everybody had enough time to learn about vm86(2) absense.
> 
> I don't think that's true. I prefer to keep the message.
> 

How about limiting the warning to some fixed number of times?
It really is trivial to get around the limiting that's in
there now...