LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Éric Piel" <Eric.Piel@tremplin-utc.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
	mitr@volny.cz, otauber@web.de, linux-kernel@vger.kernel.org,
	linux-input <linux-input@atrey.karlin.mff.cuni.cz>
Subject: Re: [PATCH 0/2] wistron_btns: More keymaps
Date: Wed, 14 Mar 2007 20:12:10 +0100	[thread overview]
Message-ID: <45F8490A.6000807@tremplin-utc.net> (raw)
In-Reply-To: <d120d5000703141202g3987d5beob3a0551d48003840@mail.gmail.com>

03/14/2007 08:02 PM, Dmitry Torokhov wrote/a écrit:
> On 3/14/07, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>> On 3/14/07, Vojtech Pavlik <vojtech@suse.cz> wrote:
>> > On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote:
>> > > Hi Eric,
>> > >
>> > > 2. I also have a concern about using KEY_SCREEN to signal toggling
>> > > display on and off. I am CCing Vojtech - he must know what the
>> > > original intent of this key code was. BTW, when user presses
>> > > corresponding button - does the display actually goes off? Maybe we
>> > > need another switch.
>> >
>> > Sorry, Dmitry, I probably should have documented it back then, I don't
>> > have the slightest idea anymore.
>> >
>>
>> That's what I was afraid of ;) Well, maybe we should just use it to
>> indicate display switch and add a comment to that effect to input.h...
>>
> 
> Oh, wait, DVB uses this code to request switchin full screen mode, we
> better not touch it.
> 
Isn't that what is supposed to do KEY_SWITCHVIDEOMODE? Humm... I've got 
a feeling that it's not clear where the documentation is or that 
documentation is missing ;-)

IIRC, about a month ago someone already asked for precision on the 
meaning of some KEY_* . It would probably worth documenting more each 
key. More specifically, it could be interesting to decide if the keycode 
has to be associated to the physical symbol displayed on the key or 
associated to the function that the user (developer) expects when 
pressing this key.

Eric

  reply	other threads:[~2007-03-14 19:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05 23:05 [PATCH] Wistron button support for TravelMate 610 Eric Piel
2007-03-06 13:36 ` Dmitry Torokhov
2007-03-06 15:26   ` Éric Piel
2007-03-13 23:01     ` [PATCH 0/2] wistron_btns: More keymaps Eric Piel
2007-03-14 13:54       ` Dmitry Torokhov
2007-03-14 15:20         ` Éric Piel
2007-03-14 15:44           ` Dmitry Torokhov
2007-03-14 18:25         ` Vojtech Pavlik
2007-03-14 18:58           ` Dmitry Torokhov
2007-03-14 19:02             ` Dmitry Torokhov
2007-03-14 19:12               ` Éric Piel [this message]
2007-03-14 19:02             ` Vojtech Pavlik
2007-03-15 10:26               ` Éric Piel
2007-03-18 21:10                 ` [PATCH 0/3] wistron_btns: More keymaps, take 2 Éric Piel
2007-03-27  3:39                   ` Dmitry Torokhov
2007-03-18 21:10                 ` [PATCH 1/3] wriston_btns: Add acerhk laptop database Éric Piel
2007-03-18 21:10                 ` [PATCH 2/3] wistron_btns: Generic keymap Éric Piel
2007-03-18 21:10                 ` [PATCH 3/3] wistron_btns: Declare keymaps as initdata Éric Piel
2007-03-19 21:28                 ` [PATCH 0/2] wistron_btns: More keymaps Dmitry Torokhov
2007-03-20  0:06                   ` Éric Piel
2007-03-13 23:05     ` [PATCH 1/2] wriston_btns: Add acerhk laptop database Eric Piel
2007-03-13 23:07     ` [PATCH 2/2] wistron_btns: Generic keymap Eric Piel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F8490A.6000807@tremplin-utc.net \
    --to=eric.piel@tremplin-utc.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitr@volny.cz \
    --cc=otauber@web.de \
    --cc=vojtech@suse.cz \
    --subject='Re: [PATCH 0/2] wistron_btns: More keymaps' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).