Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

akpm@linux-foundation.org napisał(a):
> The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to
> 
>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz
> 
> It contains the following patches against 2.6.21-rc4:
> 

Interesting

Freeing unused kernel memory: 204k freed
Write protecting the kernel read-only data: 917k
PM: Adding info for No Bus:vcs1
PM: Adding info for No Bus:vcsa1
Failed to execute /init
Kernel panic - not syncing: No init found.  Try passing init= option to kernel.

It's not a new-kernel-pkg (Fedora initrd generator) related issue, 2.6.21-rc4-git2
boots fine.

  LD      .tmp_vmlinux1
  KSYM    .tmp_kallsyms1.S
  AS      .tmp_kallsyms1.o
  LD      .tmp_vmlinux2
  KSYM    .tmp_kallsyms2.S
  AS      .tmp_kallsyms2.o
  LD      vmlinux
  SYSMAP  System.map
  SYSMAP  .tmp_System.map
  MODPOST vmlinux
WARNING: could not find versions for .tmp_versions/head.mod
WARNING: could not find versions for .tmp_versions/init_task.mod
WARNING: init/built-in.o - Section mismatch: reference to .init.text: from .text between 'rest_init' (at offset 0x101) and 'try_name'
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: arch/i386/kernel/built-in.o - Section mismatch: reference to .init.text:irqbalance_disable from .text between 'quirk_intel_irqbalance' (at offset 0x82ef) and 'i8237A_suspend'
WARNING: arch/i386/kernel/built-in.o - Section mismatch: reference to .init.text:sysenter_setup from .text between 'identify_cpu' (at offset 0x97a0) and 'display_cacheinfo'
WARNING: arch/i386/kernel/built-in.o - Section mismatch: reference to .init.text:mtrr_bp_init from .text between 'identify_cpu' (at offset 0x97aa) and 'display_cacheinfo'
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: mm/built-in.o - Section mismatch: reference to .init.data:initkmem_list3 from .text between 'set_up_list3s' (at offset 0x1c77f) and 's_start'
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
WARNING: could not find versions for .tmp_versions/built-in.mod
  AS      arch/i386/boot/setup.o
  LD      arch/i386/boot/setup
  OBJCOPY arch/i386/boot/compressed/vmlinux.bin
  GZIP    arch/i386/boot/compressed/vmlinux.bin.gz
  LD      arch/i386/boot/compressed/piggy.o
  LD      arch/i386/boot/compressed/vmlinux
  OBJCOPY arch/i386/boot/vmlinux.bin
  BUILD   arch/i386/boot/bzImage
Root device is (8, 1)
Boot sector 512 bytes.
Setup is 7025 bytes.
System is 1823 kB
Kernel: arch/i386/boot/bzImage is ready  (#3)

http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/broken-out-2007-03-18-02-44/mm-config
http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/broken-out-2007-03-18-02-44/mm-console.log

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Pekka J Enberg]

Hi Micael,

On Mon, 19 Mar 2007, Michal Piotrowski wrote:
> Pekka, can you take a look at this problem and fix my initrd? :)
> 
> GOOD
> #
> revoke-special-mmap-handling.patch
> revoke-core-code.patch
> revoke-core-code-misc-fixes.patch
> revoke-core-code-fix-shared-mapping-revoke.patch
> revoke-core-code-move-magic.patch
> revoke-support-for-ext2-and-ext3.patch
> revoke-add-documentation.patch
> revoke-wire-up-i386-system-calls.patch
> BAD

Oh, sorry about that. Can you confirm that the patch
revoke-special-mmap-handling.patch is bad? If it's not, then it must be 
the late_initcall for revokefs_init that's causing the trouble. Hmm..

			Pekka

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

On 19/03/07, Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> Hi Micael,
>
> On Mon, 19 Mar 2007, Michal Piotrowski wrote:
> > Pekka, can you take a look at this problem and fix my initrd? :)
> >
> > GOOD
> > #
> > revoke-special-mmap-handling.patch
> > revoke-core-code.patch
> > revoke-core-code-misc-fixes.patch
> > revoke-core-code-fix-shared-mapping-revoke.patch
> > revoke-core-code-move-magic.patch
> > revoke-support-for-ext2-and-ext3.patch
> > revoke-add-documentation.patch
> > revoke-wire-up-i386-system-calls.patch
> > BAD
>
> Oh, sorry about that. Can you confirm that the patch
> revoke-special-mmap-handling.patch is bad?

Yes, revoke-special-mmap-handling.patch is bad.

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

On 19/03/07, Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
> On 19/03/07, Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> > Hi Micael,
> >
> > On Mon, 19 Mar 2007, Michal Piotrowski wrote:
> > > Pekka, can you take a look at this problem and fix my initrd? :)
> > >
> > > GOOD
> > > #
> > > revoke-special-mmap-handling.patch
> > > revoke-core-code.patch
> > > revoke-core-code-misc-fixes.patch
> > > revoke-core-code-fix-shared-mapping-revoke.patch
> > > revoke-core-code-move-magic.patch
> > > revoke-support-for-ext2-and-ext3.patch
> > > revoke-add-documentation.patch
> > > revoke-wire-up-i386-system-calls.patch
> > > BAD
> >
> > Oh, sorry about that. Can you confirm that the patch
> > revoke-special-mmap-handling.patch is bad?
>
> Yes, revoke-special-mmap-handling.patch is bad.

+               if (unlikely(vma->vm_flags & VM_REVOKED))
+                       return -ENODEV;

Why -ENODEV?

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Pekka J Enberg]

On Mon, 19 Mar 2007, Michal Piotrowski wrote:
> Yes, revoke-special-mmap-handling.patch is bad.

Aah, the VM_REVOKED flag stomps on VM_CAN_INVALIDATE in -mm. Changing 
VM_REVOKED to 0x10000000 should fix it. I don't have access to kernel tree 
right now so I'll send a patch tomorrow unless someone else beats me to 
it.

				Pekka

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Pekka J Enberg]

On Mon, 19 Mar 2007, Michal Piotrowski wrote:
> > Yes, revoke-special-mmap-handling.patch is bad.
> 
> +               if (unlikely(vma->vm_flags & VM_REVOKED))
> +                       return -ENODEV;
> 
> Why -ENODEV?

That's what we want when trying to remap a revoked mapping (the vma is 
there, but you need to unmap it before reusing the region).

			Pekka

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

On 19/03/07, Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> On Mon, 19 Mar 2007, Michal Piotrowski wrote:
> > Yes, revoke-special-mmap-handling.patch is bad.
>
> Aah, the VM_REVOKED flag stomps on VM_CAN_INVALIDATE in -mm. Changing
> VM_REVOKED to 0x10000000 should fix it. I don't have access to kernel tree
> right now so I'll send a patch tomorrow unless someone else beats me to
> it.

Ok, I'll test this and submit the fix to Andrew.

>
>                                 Pekka
>

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

Michal Piotrowski napisał(a):
> On 19/03/07, Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
>> On 19/03/07, Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
>> > On Mon, 19 Mar 2007, Michal Piotrowski wrote:
>> > > Yes, revoke-special-mmap-handling.patch is bad.
>> >
>> > Aah, the VM_REVOKED flag stomps on VM_CAN_INVALIDATE in -mm. Changing
>> > VM_REVOKED to 0x10000000 should fix it.
> 
> Unfortunately it doesn't. 0x10000000 is used by VM_CAN_NONLINEAR.
> 0x20000000 should be a better value.

Here is a tested patch.

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Signed-off-by: Pekka J Enberg <penberg@cs.helsinki.fi>

--- linux-work1-clean/include/linux/mm.h	2007-03-19 18:52:28.000000000 +0100
+++ linux-work1/include/linux/mm.h	2007-03-19 18:23:04.000000000 +0100
@@ -173,7 +173,6 @@ extern int do_mprotect(unsigned long sta
 #define VM_MAPPED_COPY	0x01000000	/* T if mapped copy of data (nommu mmap) */
 #define VM_INSERTPAGE	0x02000000	/* The vma has had "vm_insert_page()" done on it */
 #define VM_ALWAYSDUMP	0x04000000	/* Always include in core dumps */
-#define VM_REVOKED	0x08000000	/* Mapping has been revoked */
 
 #define VM_CAN_INVALIDATE 0x08000000	/* The mapping may be invalidated,
 					 * eg. truncate or invalidate_inode_*.
@@ -181,6 +180,7 @@ extern int do_mprotect(unsigned long sta
 					 * return with the page locked.
 					 */
 #define VM_CAN_NONLINEAR 0x10000000	/* Has ->fault & does nonlinear pages */
+#define VM_REVOKED	0x20000000	/* Mapping has been revoked */
 
 #ifndef VM_STACK_DEFAULT_FLAGS		/* arch can override this */
 #define VM_STACK_DEFAULT_FLAGS VM_DATA_DEFAULT_FLAGS

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Pekka J Enberg]

On Mon, 19 Mar 2007, Michal Piotrowski wrote:
> Here is a tested patch.

[snip]

> Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
> Signed-off-by: Pekka J Enberg <penberg@cs.helsinki.fi>

You're not supposed to add sign-offs for anyone else but yourself. This 
patch did not pass through me so please remove it.

Anyway, the fix looks good. Thanks.

Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

akpm@linux-foundation.org napisał(a):
> The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to
> 
>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz
> 
> It contains the following patches against 2.6.21-rc4:
> 

------------[ cut here ]------------
kernel BUG at mm/filemap.c:123!
invalid opcode: 0000 [#1]
PREEMPT SMP 
last sysfs file: devices/platform/w83627hf.656/temp2_input
Modules linked in: ipt_MASQUERADE iptable_nat nf_nat nfsd exportfs lockd nfs_acl autofs4 sunrpc af_packet nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink iptable_filter ip_tables ip6t_REJECT xt_tcpudp ip6table_filter ip6_tables x_tables ipv6 binfmt_misc thermal processor fan container nvram snd_intel8x0 snd_ac97_codec ac97_bus snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss evdev snd_mixer_oss snd_pcm intel_agp agpgart snd_timer snd soundcore i2c_i801 snd_page_alloc ide_cd cdrom rtc unix
CPU:    0
EIP:    0060:[<c01615de>]    Not tainted VLI
EFLAGS: 00010002   (2.6.21-rc4-mm1 #13)
EIP is at __remove_from_page_cache+0x42/0x4a
eax: 00000001   ebx: ca263a58   ecx: c043c968   edx: 00000001
esi: c6ad3480   edi: 00000000   ebp: c968dde8   esp: c968dde0
ds: 007b   es: 007b   fs: 00d8  gs: 0033  ss: 0068
Process bash-shared-map (pid: 12273, ti=c968c000 task=c78bc030 task.ti=c968c000)
Stack: ca263a68 c6ad3480 c968ddf8 c016161b c6ad3480 000000da c968de04 c016824d 
       c6ad3480 c968de88 c0168525 00001000 00000000 00000000 d17dc000 0005a91a 
       00000000 ca263a58 0000005b ffffffff 0000091a 00000110 c54eb5e0 00000004 
Call Trace:
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c0105308>] show_stack_log_lvl+0x9d/0xac
 [<c0105504>] show_registers+0x1ed/0x34c
 [<c0105780>] die+0x11d/0x234
 [<c0105921>] do_trap+0x8a/0xa3
 [<c010620a>] do_invalid_op+0x97/0xa1
 [<c033f87c>] error_code+0x7c/0x84
 [<c016161b>] remove_from_page_cache+0x35/0x40
 [<c016824d>] truncate_complete_page+0x38/0x42
 [<c0168525>] truncate_inode_pages_range+0x2ce/0x2fe
 [<c016856f>] truncate_inode_pages+0x1a/0x1c
 [<c016ebcc>] vmtruncate+0x40/0xbb
 [<c0193c61>] inode_setattr+0x5c/0x137
 [<c01c328d>] ext3_setattr+0x19c/0x1f8
 [<c0193e75>] notify_change+0x139/0x2ec
 [<c017f666>] do_truncate+0x53/0x6c
 [<c017facc>] do_sys_ftruncate+0x135/0x150
 [<c017fb02>] sys_ftruncate64+0x1b/0x1d
 [<c0104270>] syscall_call+0x7/0xb
 =======================
Code: 10 00 00 00 00 ff 4b 68 ba 05 00 00 00 89 f0 e8 17 95 00 00 31 d2 83 7e 08 00 0f 99 c2 b8 68 c9 43 c0 e8 1e 26 0b 00 85 c0 74 04 <0f> 0b eb fe 5b 5e 5d c3 55 89 e5 56 53 89 c6 8b 58 10 8b 10 83 
EIP: [<c01615de>] __remove_from_page_cache+0x42/0x4a SS:ESP 0068:c968dde0

0xc01615de is in __remove_from_page_cache (mm/filemap.c:123).
118
119             radix_tree_delete(&mapping->page_tree, page->index);
120             page->mapping = NULL;
121             mapping->nrpages--;
122             __dec_zone_page_state(page, NR_FILE_PAGES);
123             BUG_ON(page_mapped(page));
124     }
125
126     void remove_from_page_cache(struct page *page)
127     {


note: bash-shared-map[12273] exited with preempt_count 1
BUG: sleeping function called from invalid context at kernel/rwsem.c:20
in_atomic():1, irqs_disabled():1
3 locks held by bash-shared-map/12273:
 #0:  (&inode->i_mutex){--..}, at: [<c033d89a>] mutex_lock+0x1c/0x1f
 #1:  (&inode->i_alloc_sem){--..}, at: [<c0193e1b>] notify_change+0xdf/0x2ec
 #2:  (&inode->i_data.tree_lock){++..}, at: [<c0161614>] remove_from_page_cache+0x2e/0x40

l *0xc033d89a
0xc033d89a is in mutex_lock (kernel/mutex.c:92).
87              /*
88               * The locking fastpath is the 1->0 transition from
89               * 'unlocked' into 'locked' state.
90               */
91              __mutex_fastpath_lock(&lock->count, __mutex_lock_slowpath);
92      }
93
94      EXPORT_SYMBOL(mutex_lock);
95
96      static void fastcall noinline __sched

l *0xc0193e1b
0xc0193e1b is in notify_change (fs/attr.c:146).
141                     return 0;
142
143             if (ia_valid & ATTR_SIZE)
144                     down_write(&dentry->d_inode->i_alloc_sem);
145
146             if (inode->i_op && inode->i_op->setattr) {
147                     error = security_inode_setattr(dentry, attr);
148                     if (!error)
149                             error = inode->i_op->setattr(dentry, attr);
150             } else {

l *0xc0161614
0xc0161614 is in remove_from_page_cache (mm/filemap.c:133).
128             struct address_space *mapping = page->mapping;
129
130             BUG_ON(!PageLocked(page));
131
132             write_lock_irq(&mapping->tree_lock);
133             __remove_from_page_cache(page);
134             write_unlock_irq(&mapping->tree_lock);
135     }
136
137     static int sync_page(void *word)


irq event stamp: 1313898
hardirqs last  enabled at (1313897): [<c017bafa>] kmem_cache_free+0xf7/0x100
hardirqs last disabled at (1313898): [<c033f043>] _write_lock_irq+0xf/0x48
softirqs last  enabled at (1313800): [<c0128e58>] __do_softirq+0xe4/0xea
softirqs last disabled at (1313795): [<c0128e97>] do_softirq+0x39/0x55

l *0xc017bafa
0xc017bafa is in kmem_cache_free (include/asm/irqflags.h:33).
28              return flags;
29      }
30
31      static inline void raw_local_irq_restore(unsigned long flags)
32      {
33              __asm__ __volatile__(
34                      "pushl %0 ; popfl"
35                      : /* no output */
36                      :"g" (flags)
37                      :"memory", "cc"

l *0xc033f043
0xc033f043 is in _write_lock_irq (kernel/spinlock.c:167).
162     EXPORT_SYMBOL(_write_lock_irqsave);
163
164     void __lockfunc _write_lock_irq(rwlock_t *lock)
165     {
166             local_irq_disable();
167             preempt_disable();
168             rwlock_acquire(&lock->dep_map, 0, 0, _RET_IP_);
169             _raw_write_lock(lock);
170     }
171     EXPORT_SYMBOL(_write_lock_irq);

l *0xc0128e58
0xc0128e58 is in __do_softirq (kernel/softirq.c:252).
247
248             trace_softirq_exit();
249
250             account_system_vtime(current);
251             _local_bh_enable();
252     }
253
254     #ifndef __ARCH_HAS_DO_SOFTIRQ
255
256     asmlinkage void do_softirq(void)

l *0xc0128e97
0xc0128e97 is in do_softirq (kernel/softirq.c:271).
266             pending = local_softirq_pending();
267
268             if (pending)
269                     __do_softirq();
270
271             local_irq_restore(flags);
272     }
273
274     EXPORT_SYMBOL(do_softirq);


 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c011cd71>] __might_sleep+0xc9/0xcf
 [<c0139b12>] down_read+0x18/0x4c
 [<c014ef71>] acct_collect+0x3b/0x146
 [<c0126fb9>] do_exit+0x254/0x86c
 [<c0105871>] die+0x20e/0x234
 [<c0105921>] do_trap+0x8a/0xa3
 [<c010620a>] do_invalid_op+0x97/0xa1
 [<c033f87c>] error_code+0x7c/0x84
 [<c016161b>] remove_from_page_cache+0x35/0x40
 [<c016824d>] truncate_complete_page+0x38/0x42
 [<c0168525>] truncate_inode_pages_range+0x2ce/0x2fe
 [<c016856f>] truncate_inode_pages+0x1a/0x1c
 [<c016ebcc>] vmtruncate+0x40/0xbb
 [<c0193c61>] inode_setattr+0x5c/0x137
 [<c01c328d>] ext3_setattr+0x19c/0x1f8
 [<c0193e75>] notify_change+0x139/0x2ec
 [<c017f666>] do_truncate+0x53/0x6c
 [<c017facc>] do_sys_ftruncate+0x135/0x150
 [<c017fb02>] sys_ftruncate64+0x1b/0x1d
 [<c0104270>] syscall_call+0x7/0xb
 =======================
BUG: scheduling while atomic: bash-shared-map/0x10000001/12273
3 locks held by bash-shared-map/12273:
 #0:  (&inode->i_mutex){--..}, at: [<c033d89a>] mutex_lock+0x1c/0x1f
 #1:  (&inode->i_alloc_sem){--..}, at: [<c0193e1b>] notify_change+0xdf/0x2ec
 #2:  (&inode->i_data.tree_lock){++..}, at: [<c0161614>] remove_from_page_cache+0x2e/0x40
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c033ba9a>] __sched_text_start+0x92/0xb25
 [<c011eed7>] __cond_resched+0x21/0x4b
 [<c033c85d>] cond_resched+0x3c/0x47
 [<c016cf02>] unmap_vmas+0x471/0x560
 [<c016fc38>] exit_mmap+0x7e/0x12a
 [<c0121db7>] mmput+0x49/0xaf
 [<c0125a69>] exit_mm+0xe5/0xeb
 [<c012700c>] do_exit+0x2a7/0x86c
 [<c0105871>] die+0x20e/0x234
 [<c0105921>] do_trap+0x8a/0xa3
 [<c010620a>] do_invalid_op+0x97/0xa1
 [<c033f87c>] error_code+0x7c/0x84
 [<c016161b>] remove_from_page_cache+0x35/0x40
 [<c016824d>] truncate_complete_page+0x38/0x42
 [<c0168525>] truncate_inode_pages_range+0x2ce/0x2fe
 [<c016856f>] truncate_inode_pages+0x1a/0x1c
 [<c016ebcc>] vmtruncate+0x40/0xbb
 [<c0193c61>] inode_setattr+0x5c/0x137
 [<c01c328d>] ext3_setattr+0x19c/0x1f8
 [<c0193e75>] notify_change+0x139/0x2ec
 [<c017f666>] do_truncate+0x53/0x6c
 [<c017facc>] do_sys_ftruncate+0x135/0x150
 [<c017fb02>] sys_ftruncate64+0x1b/0x1d
 [<c0104270>] syscall_call+0x7/0xb
 =======================
BUG: soft lockup detected on CPU#0!
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c015698d>] softlockup_tick+0xca/0xdc
 [<c012c7b5>] run_local_timers+0x12/0x14
 [<c012cbc3>] update_process_times+0x3e/0x63
 [<c013d29f>] tick_sched_timer+0x5d/0xa1
 [<c01397dd>] hrtimer_interrupt+0x11e/0x1b9
 [<c0115daa>] smp_apic_timer_interrupt+0x72/0x84
 [<c0104d33>] apic_timer_interrupt+0x33/0x38
 [<c0113d26>] flush_tlb_page+0x86/0xb8
 [<c0172644>] page_referenced_one+0x90/0xd1
 [<c017317d>] page_referenced+0x64/0xd0
 [<c0168b3d>] shrink_active_list+0x169/0x426
 [<c01698f6>] shrink_zone+0xb9/0xf8
 [<c016a33e>] try_to_free_pages+0x155/0x223
 [<c016498c>] __alloc_pages+0x1cd/0x324
 [<c016c570>] do_wp_page+0x263/0x4a6
 [<c016db99>] __handle_mm_fault+0x6db/0x72c
 [<c011a694>] do_page_fault+0x22b/0x55b
 [<c033f87c>] error_code+0x7c/0x84
 =======================
BUG: soft lockup detected on CPU#0!
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c015698d>] softlockup_tick+0xca/0xdc
 [<c012c7b5>] run_local_timers+0x12/0x14
 [<c012cbc3>] update_process_times+0x3e/0x63
 [<c013d29f>] tick_sched_timer+0x5d/0xa1
 [<c01397dd>] hrtimer_interrupt+0x11e/0x1b9
 [<c0115daa>] smp_apic_timer_interrupt+0x72/0x84
 [<c0104d33>] apic_timer_interrupt+0x33/0x38
 [<c0113d26>] flush_tlb_page+0x86/0xb8
 [<c0172644>] page_referenced_one+0x90/0xd1
 [<c017317d>] page_referenced+0x64/0xd0
 [<c0168b3d>] shrink_active_list+0x169/0x426
 [<c01698f6>] shrink_zone+0xb9/0xf8
 [<c016a33e>] try_to_free_pages+0x155/0x223
 [<c016498c>] __alloc_pages+0x1cd/0x324
 [<c016c570>] do_wp_page+0x263/0x4a6
 [<c016db99>] __handle_mm_fault+0x6db/0x72c
 [<c011a694>] do_page_fault+0x22b/0x55b
 [<c033f87c>] error_code+0x7c/0x84
 =======================
BUG: soft lockup detected on CPU#0!
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c015698d>] softlockup_tick+0xca/0xdc
 [<c012c7b5>] run_local_timers+0x12/0x14
 [<c012cbc3>] update_process_times+0x3e/0x63
 [<c013d29f>] tick_sched_timer+0x5d/0xa1
 [<c01397dd>] hrtimer_interrupt+0x11e/0x1b9
 [<c0115daa>] smp_apic_timer_interrupt+0x72/0x84
 [<c0104d33>] apic_timer_interrupt+0x33/0x38
 [<c0113d26>] flush_tlb_page+0x86/0xb8
 [<c0172644>] page_referenced_one+0x90/0xd1
 [<c017317d>] page_referenced+0x64/0xd0
 [<c0168b3d>] shrink_active_list+0x169/0x426
 [<c01698f6>] shrink_zone+0xb9/0xf8
 [<c016a33e>] try_to_free_pages+0x155/0x223
 [<c016498c>] __alloc_pages+0x1cd/0x324
 [<c016c570>] do_wp_page+0x263/0x4a6
 [<c016db99>] __handle_mm_fault+0x6db/0x72c
 [<c011a694>] do_page_fault+0x22b/0x55b
 [<c033f87c>] error_code+0x7c/0x84
 =======================
BUG: soft lockup detected on CPU#0!
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c015698d>] softlockup_tick+0xca/0xdc
 [<c012c7b5>] run_local_timers+0x12/0x14
 [<c012cbc3>] update_process_times+0x3e/0x63
 [<c013d29f>] tick_sched_timer+0x5d/0xa1
 [<c01397dd>] hrtimer_interrupt+0x11e/0x1b9
 [<c0115daa>] smp_apic_timer_interrupt+0x72/0x84
 [<c0104d33>] apic_timer_interrupt+0x33/0x38
 [<c0113d26>] flush_tlb_page+0x86/0xb8
 [<c0172644>] page_referenced_one+0x90/0xd1
 [<c017317d>] page_referenced+0x64/0xd0
 [<c0168b3d>] shrink_active_list+0x169/0x426
 [<c01698f6>] shrink_zone+0xb9/0xf8
 [<c016a33e>] try_to_free_pages+0x155/0x223
 [<c016498c>] __alloc_pages+0x1cd/0x324
 [<c016c570>] do_wp_page+0x263/0x4a6
 [<c016db99>] __handle_mm_fault+0x6db/0x72c
 [<c011a694>] do_page_fault+0x22b/0x55b
 [<c033f87c>] error_code+0x7c/0x84
 =======================
BUG: soft lockup detected on CPU#0!
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c015698d>] softlockup_tick+0xca/0xdc
 [<c012c7b5>] run_local_timers+0x12/0x14
 [<c012cbc3>] update_process_times+0x3e/0x63
 [<c013d29f>] tick_sched_timer+0x5d/0xa1
 [<c01397dd>] hrtimer_interrupt+0x11e/0x1b9
 [<c0115daa>] smp_apic_timer_interrupt+0x72/0x84
 [<c0104d33>] apic_timer_interrupt+0x33/0x38
 [<c0113d26>] flush_tlb_page+0x86/0xb8
 [<c0172644>] page_referenced_one+0x90/0xd1
 [<c017317d>] page_referenced+0x64/0xd0
 [<c0168b3d>] shrink_active_list+0x169/0x426
 [<c01698f6>] shrink_zone+0xb9/0xf8
 [<c016a33e>] try_to_free_pages+0x155/0x223
 [<c016498c>] __alloc_pages+0x1cd/0x324
 [<c016c570>] do_wp_page+0x263/0x4a6
 [<c016db99>] __handle_mm_fault+0x6db/0x72c
 [<c011a694>] do_page_fault+0x22b/0x55b
 [<c033f87c>] error_code+0x7c/0x84
 =======================
BUG: soft lockup detected on CPU#0!
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c015698d>] softlockup_tick+0xca/0xdc
 [<c012c7b5>] run_local_timers+0x12/0x14
 [<c012cbc3>] update_process_times+0x3e/0x63
 [<c013d29f>] tick_sched_timer+0x5d/0xa1
 [<c01397dd>] hrtimer_interrupt+0x11e/0x1b9
 [<c0115daa>] smp_apic_timer_interrupt+0x72/0x84
 [<c0104d33>] apic_timer_interrupt+0x33/0x38
 [<c0113d26>] flush_tlb_page+0x86/0xb8
 [<c0172644>] page_referenced_one+0x90/0xd1
 [<c017317d>] page_referenced+0x64/0xd0
 [<c0168b3d>] shrink_active_list+0x169/0x426
 [<c01698f6>] shrink_zone+0xb9/0xf8
 [<c016a33e>] try_to_free_pages+0x155/0x223
 [<c016498c>] __alloc_pages+0x1cd/0x324
 [<c016c570>] do_wp_page+0x263/0x4a6
 [<c016db99>] __handle_mm_fault+0x6db/0x72c
 [<c011a694>] do_page_fault+0x22b/0x55b
 [<c033f87c>] error_code+0x7c/0x84
 =======================

http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/broken-out-2007-03-18-02-44/mm-config

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

On 19/03/07, Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> On Mon, 19 Mar 2007, Michal Piotrowski wrote:
> > Here is a tested patch.
>
> [snip]
>
> > Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
> > Signed-off-by: Pekka J Enberg <penberg@cs.helsinki.fi>
>
> You're not supposed to add sign-offs for anyone else but yourself. This
> patch did not pass through me so please remove it.

I manipulated your signed-off. I'm sorry.

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

Hi Ingo,

On 18/03/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to
>
>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz
>
> It contains the following patches against 2.6.21-rc4:

I reported this a few days ago.

  BUG: at kernel/lockdep.c:2428 check_flags()
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c013e1b5>] check_flags+0xb7/0x187
 [<c01413ea>] lock_acquire+0x3a/0x93
 [<c033ef57>] _spin_lock+0x35/0x42
 [<c014a957>] refrigerator+0x14/0xb5
 [<c012efe6>] get_signal_to_deliver+0x42/0x709
 [<c0103786>] do_notify_resume+0x94/0x778
 [<c0104339>] work_notifysig+0x13/0x1a
 =======================
irq event stamp: 178563
hardirqs last  enabled at (178563): [<c0104391>] syscall_exit_work+0x11/0x26
hardirqs last disabled at (178562): [<c010427d>] syscall_exit+0x9/0x1a
softirqs last  enabled at (178170): [<c0128e58>] __do_softirq+0xe4/0xea
softirqs last disabled at (178163): [<c0128e97>] do_softirq+0x39/0x55
hardirqs last  enabled at (2825): [<c033f525>] _spin_unlock_irqrestore+0x36/0x69
hardirqs last disabled at (2826): [<c033f1a7>] _spin_lock_irqsave+0x12/0x4e
softirqs last  enabled at (2808): [<c0128e58>] __do_softirq+0xe4/0xea
softirqs last disabled at (2801): [<c0128e97>] do_softirq+0x39/0x55

cpu-hotplug test hangs on this

CPU 1 is now offline
lockdep: not fixing up alternatives.
BUG: at kernel/lockdep.c:2430 check_flags()

http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/broken-out-2007-03-18-02-44/mm-config
http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/broken-out-2007-03-18-02-44/mm-console3-swsusp-and-cpu-hotplug.log

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Andrew Morton]

On Mon, 19 Mar 2007 20:23:40 +0100
Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:

> akpm@linux-foundation.org napisał(a):
> > The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to
> > 
> >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz
> > 
> > It contains the following patches against 2.6.21-rc4:
> > 
> 
> ------------[ cut here ]------------
> kernel BUG at mm/filemap.c:123!
> invalid opcode: 0000 [#1]
> PREEMPT SMP 
> last sysfs file: devices/platform/w83627hf.656/temp2_input
> Modules linked in: ipt_MASQUERADE iptable_nat nf_nat nfsd exportfs lockd nfs_acl autofs4 sunrpc af_packet nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink iptable_filter ip_tables ip6t_REJECT xt_tcpudp ip6table_filter ip6_tables x_tables ipv6 binfmt_misc thermal processor fan container nvram snd_intel8x0 snd_ac97_codec ac97_bus snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss evdev snd_mixer_oss snd_pcm intel_agp agpgart snd_timer snd soundcore i2c_i801 snd_page_alloc ide_cd cdrom rtc unix
> CPU:    0
> EIP:    0060:[<c01615de>]    Not tainted VLI
> EFLAGS: 00010002   (2.6.21-rc4-mm1 #13)
> EIP is at __remove_from_page_cache+0x42/0x4a
> eax: 00000001   ebx: ca263a58   ecx: c043c968   edx: 00000001
> esi: c6ad3480   edi: 00000000   ebp: c968dde8   esp: c968dde0
> ds: 007b   es: 007b   fs: 00d8  gs: 0033  ss: 0068
> Process bash-shared-map (pid: 12273, ti=c968c000 task=c78bc030 task.ti=c968c000)
> Stack: ca263a68 c6ad3480 c968ddf8 c016161b c6ad3480 000000da c968de04 c016824d 
>        c6ad3480 c968de88 c0168525 00001000 00000000 00000000 d17dc000 0005a91a 
>        00000000 ca263a58 0000005b ffffffff 0000091a 00000110 c54eb5e0 00000004 
> Call Trace:
>  [<c0105256>] show_trace_log_lvl+0x1a/0x2f
>  [<c0105308>] show_stack_log_lvl+0x9d/0xac
>  [<c0105504>] show_registers+0x1ed/0x34c
>  [<c0105780>] die+0x11d/0x234
>  [<c0105921>] do_trap+0x8a/0xa3
>  [<c010620a>] do_invalid_op+0x97/0xa1
>  [<c033f87c>] error_code+0x7c/0x84
>  [<c016161b>] remove_from_page_cache+0x35/0x40
>  [<c016824d>] truncate_complete_page+0x38/0x42
>  [<c0168525>] truncate_inode_pages_range+0x2ce/0x2fe
>  [<c016856f>] truncate_inode_pages+0x1a/0x1c
>  [<c016ebcc>] vmtruncate+0x40/0xbb
>  [<c0193c61>] inode_setattr+0x5c/0x137
>  [<c01c328d>] ext3_setattr+0x19c/0x1f8
>  [<c0193e75>] notify_change+0x139/0x2ec
>  [<c017f666>] do_truncate+0x53/0x6c
>  [<c017facc>] do_sys_ftruncate+0x135/0x150
>  [<c017fb02>] sys_ftruncate64+0x1b/0x1d
>  [<c0104270>] syscall_call+0x7/0xb

Ugly - it's hard to determine which patch might have caused that, but I
bet it was Nick ;)

How hard is it to reproduce?

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Andrew Morton]

On Sun, 18 Mar 2007 19:35:48 +0100
Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:

> WARNING: could not find versions for .tmp_versions/built-in.mod
> WARNING: could not find versions for .tmp_versions/built-in.mod
> WARNING: could not find versions for .tmp_versions/built-in.mod
> WARNING: could not find versions for .tmp_versions/built-in.mod
> WARNING: could not find versions for .tmp_versions/built-in.mod
> WARNING: could not find versions for .tmp_versions/built-in.mod

This is caused by git-kbuild.  I don't know what the significance of it is.

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Andrew Morton]

On Mon, 19 Mar 2007 22:37:46 +0100 "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com> wrote:

> On 19/03/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Mon, 19 Mar 2007 20:23:40 +0100
> > Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
> >
> > > akpm@linux-foundation.org napisał(a):
> > > > The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to
> > > >
> > > >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz
> > > >
> > > > It contains the following patches against 2.6.21-rc4:
> > > >
> > >
> > > ------------[ cut here ]------------
> > > kernel BUG at mm/filemap.c:123!
> > > invalid opcode: 0000 [#1]
> > > PREEMPT SMP
> > > last sysfs file: devices/platform/w83627hf.656/temp2_input
> > > Modules linked in: ipt_MASQUERADE iptable_nat nf_nat nfsd exportfs lockd nfs_acl autofs4 sunrpc af_packet nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink iptable_filter ip_tables ip6t_REJECT xt_tcpudp ip6table_filter ip6_tables x_tables ipv6 binfmt_misc thermal processor fan container nvram snd_intel8x0 snd_ac97_codec ac97_bus snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss evdev snd_mixer_oss snd_pcm intel_agp agpgart snd_timer snd soundcore i2c_i801 snd_page_alloc ide_cd cdrom rtc unix
> > > CPU:    0
> > > EIP:    0060:[<c01615de>]    Not tainted VLI
> > > EFLAGS: 00010002   (2.6.21-rc4-mm1 #13)
> > > EIP is at __remove_from_page_cache+0x42/0x4a
> > > eax: 00000001   ebx: ca263a58   ecx: c043c968   edx: 00000001
> > > esi: c6ad3480   edi: 00000000   ebp: c968dde8   esp: c968dde0
> > > ds: 007b   es: 007b   fs: 00d8  gs: 0033  ss: 0068
> > > Process bash-shared-map (pid: 12273, ti=c968c000 task=c78bc030 task.ti=c968c000)
> > > Stack: ca263a68 c6ad3480 c968ddf8 c016161b c6ad3480 000000da c968de04 c016824d
> > >        c6ad3480 c968de88 c0168525 00001000 00000000 00000000 d17dc000 0005a91a
> > >        00000000 ca263a58 0000005b ffffffff 0000091a 00000110 c54eb5e0 00000004
> > > Call Trace:
> > >  [<c0105256>] show_trace_log_lvl+0x1a/0x2f
> > >  [<c0105308>] show_stack_log_lvl+0x9d/0xac
> > >  [<c0105504>] show_registers+0x1ed/0x34c
> > >  [<c0105780>] die+0x11d/0x234
> > >  [<c0105921>] do_trap+0x8a/0xa3
> > >  [<c010620a>] do_invalid_op+0x97/0xa1
> > >  [<c033f87c>] error_code+0x7c/0x84
> > >  [<c016161b>] remove_from_page_cache+0x35/0x40
> > >  [<c016824d>] truncate_complete_page+0x38/0x42
> > >  [<c0168525>] truncate_inode_pages_range+0x2ce/0x2fe
> > >  [<c016856f>] truncate_inode_pages+0x1a/0x1c
> > >  [<c016ebcc>] vmtruncate+0x40/0xbb
> > >  [<c0193c61>] inode_setattr+0x5c/0x137
> > >  [<c01c328d>] ext3_setattr+0x19c/0x1f8
> > >  [<c0193e75>] notify_change+0x139/0x2ec
> > >  [<c017f666>] do_truncate+0x53/0x6c
> > >  [<c017facc>] do_sys_ftruncate+0x135/0x150
> > >  [<c017fb02>] sys_ftruncate64+0x1b/0x1d
> > >  [<c0104270>] syscall_call+0x7/0xb
> >
> > Ugly - it's hard to determine which patch might have caused that, but I
> > bet it was Nick ;)
> >
> > How hard is it to reproduce?
> 
> I think that it's very easy - run bash_shared_mapping from AutoTest
> for a few seconds.
> 

Yeah, a simple `bash-shared-mapping foo 100000000' goes splat after a few
seconds.

Which indicates that the patchset just isn't working as intended, I think. 
Nick, did you ever run bash-shared-mapping on it?  You should - it's kinda
evil.

I could just drop the BUG_ON, or I could drop the whole patch series.

<dithers>

The kernel with Nick's patchset but without the assert seems to run OK. 
But presumably it's anonymising mapped pages, which is bad.

The kernel without Nick's patchset but with the assert runs OK too.  Under
the principle of mm-has-been-too-flakey-lately, I'll drop the patches:

mm-debug-check-for-the-fault-vs-invalidate-race.patch
mm-simplify-filemap_nopage.patch
mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch
mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch
mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-tidy.patch
mm-merge-nopfn-into-fault.patch
mm-merge-nopfn-into-fault-fix.patch
mm-remove-legacy-cruft.patch

A rollup against rc4 which includes the above patches and which is suitable
for raising fixups against is at http://userweb.kernel.org/~akpm/np.gz

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Andrew Morton]

On Mon, 19 Mar 2007 17:58:52 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> The kernel without Nick's patchset but with the assert runs OK too.  Under
> the principle of mm-has-been-too-flakey-lately, I'll drop the patches:
> 
> mm-debug-check-for-the-fault-vs-invalidate-race.patch
> mm-simplify-filemap_nopage.patch
> mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch
> mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch
> mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-tidy.patch
> mm-merge-nopfn-into-fault.patch
> mm-merge-nopfn-into-fault-fix.patch
> mm-remove-legacy-cruft.patch

ug, too many rejects.  I'll leave them in, minus
mm-debug-check-for-the-fault-vs-invalidate-race.patch

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Nick Piggin]

Andrew Morton wrote:
> On Mon, 19 Mar 2007 17:58:52 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> 
>>The kernel without Nick's patchset but with the assert runs OK too.  Under
>>the principle of mm-has-been-too-flakey-lately, I'll drop the patches:
>>
>>mm-debug-check-for-the-fault-vs-invalidate-race.patch
>>mm-simplify-filemap_nopage.patch
>>mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch
>>mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch
>>mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-tidy.patch
>>mm-merge-nopfn-into-fault.patch
>>mm-merge-nopfn-into-fault-fix.patch
>>mm-remove-legacy-cruft.patch
> 
> 
> ug, too many rejects.  I'll leave them in, minus
> mm-debug-check-for-the-fault-vs-invalidate-race.patch
> 

Hang on a sec... I'll try fixing the thing before you next make a
release.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Andrew Morton]

On Tue, 20 Mar 2007 13:47:53 +1100 Nick Piggin <nickpiggin@yahoo.com.au> wrote:

> Andrew Morton wrote:
> > On Mon, 19 Mar 2007 17:58:52 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> > 
> > 
> >>The kernel without Nick's patchset but with the assert runs OK too.  Under
> >>the principle of mm-has-been-too-flakey-lately, I'll drop the patches:
> >>
> >>mm-debug-check-for-the-fault-vs-invalidate-race.patch
> >>mm-simplify-filemap_nopage.patch
> >>mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch
> >>mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch
> >>mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-tidy.patch
> >>mm-merge-nopfn-into-fault.patch
> >>mm-merge-nopfn-into-fault-fix.patch
> >>mm-remove-legacy-cruft.patch
> > 
> > 
> > ug, too many rejects.  I'll leave them in, minus
> > mm-debug-check-for-the-fault-vs-invalidate-race.patch
> > 
> 
> Hang on a sec... I'll try fixing the thing before you next make a
> release.
> 

Too late.  hot-fixes/ awaits thee.

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Nick Piggin]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Andrew Morton wrote:
> On Tue, 20 Mar 2007 13:47:53 +1100 Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> 
> 
>>Andrew Morton wrote:
>>

>>Hang on a sec... I'll try fixing the thing before you next make a
>>release.
>>
> 
> 
> Too late.  hot-fixes/ awaits thee.

Awww... well thanks very much Michal for reporting the bug, I reproduced
it easily and it turns out to be a typo.

In my testing I never had a lot of writeout going on, so most of the pages
will have been truncated in the first loop...

-- 
SUSE Labs, Novell Inc.

[-- Attachment #2: mm-dnp-invp-race-fix.patch --]
[-- Type: text/plain, Size: 525 bytes --]

Fix typo in do_no_page vs invalidate race fix patch.

Index: linux-2.6/mm/truncate.c
===================================================================
--- linux-2.6.orig/mm/truncate.c
+++ linux-2.6/mm/truncate.c
@@ -235,7 +235,7 @@ void truncate_inode_pages_range(struct a
 			wait_on_page_writeback(page);
 			if (page_mapped(page)) {
 				unmap_mapping_range(mapping,
-				  (loff_t)page_index<<PAGE_CACHE_SHIFT,
+				  (loff_t)page->index<<PAGE_CACHE_SHIFT,
 				  PAGE_CACHE_SIZE, 0);
 			}
 			if (page->index > next)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Nick Piggin]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Nick Piggin wrote:
> Andrew Morton wrote:
> 
>> On Tue, 20 Mar 2007 13:47:53 +1100 Nick Piggin 
>> <nickpiggin@yahoo.com.au> wrote:
>>
>>
>>> Andrew Morton wrote:
>>>
> 
>>> Hang on a sec... I'll try fixing the thing before you next make a
>>> release.
>>>
>>
>>
>> Too late.  hot-fixes/ awaits thee.
> 
> 
> Awww... well thanks very much Michal for reporting the bug, I reproduced
> it easily and it turns out to be a typo.
> 
> In my testing I never had a lot of writeout going on, so most of the pages
> will have been truncated in the first loop...

Also, noticed another problem in the same general area. Andrew you were
indeed right to question the removal of that unmap_mapping_range call,
but I think even it alone it wasn't enough...

-- 
SUSE Labs, Novell Inc.

[-- Attachment #2: mm-dnp-invp-race-fix2.patch --]
[-- Type: text/plain, Size: 1551 bytes --]

The nopage vs invalidate race fix patch did not take care of truncating
private COW pages. Mind you, I'm pretty sure this was previously racy
even for regular truncate, not to mention vmtruncate_range.

Anyway, fix that omission.

Index: linux-2.6/mm/memory.c
===================================================================
--- linux-2.6.orig/mm/memory.c
+++ linux-2.6/mm/memory.c
@@ -1905,7 +1905,18 @@ int vmtruncate(struct inode * inode, lof
 	if (IS_SWAPFILE(inode))
 		goto out_busy;
 	i_size_write(inode, offset);
+
+	/*
+	 * unmap_mapping_range is called twice, first simply for efficiency
+	 * so that truncate_inode_pages does fewer single-page unmaps. However
+	 * after this first call, and before truncate_inode_pages finishes,
+	 * it is possible for private pages to be COWed, which remain after
+	 * truncate_inode_pages finishes, hence the second unmap_mapping_range
+	 * call must be made for correctness.
+	 */
+	unmap_mapping_range(mapping, offset + PAGE_SIZE - 1, 0, 1);
 	truncate_inode_pages(mapping, offset);
+	unmap_mapping_range(mapping, offset + PAGE_SIZE - 1, 0, 1);
 	goto out_truncate;
 
 do_expand:
@@ -1943,7 +1954,9 @@ int vmtruncate_range(struct inode *inode
 
 	mutex_lock(&inode->i_mutex);
 	down_write(&inode->i_alloc_sem);
+	unmap_mapping_range(mapping, offset, (end - offset), 1);
 	truncate_inode_pages_range(mapping, offset, end);
+	unmap_mapping_range(mapping, offset, (end - offset), 1);
 	inode->i_op->truncate_range(inode, offset, end);
 	up_write(&inode->i_alloc_sem);
 	mutex_unlock(&inode->i_mutex);

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

akpm@linux-foundation.org napisał(a):
> The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to
> 
>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz
> 
> It contains the following patches against 2.6.21-rc4:

PM: Adding info for No Bus:vcsa7
BUG: at kernel/lockdep.c:2430 check_flags()
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c013e1b5>] check_flags+0xb7/0x187
 [<c01413ea>] lock_acquire+0x3a/0x93
 [<c0139a64>] down_write+0x3a/0x54
 [<c0170563>] sys_munmap+0x23/0x3f
 [<c0104270>] syscall_call+0x7/0xb
 =======================
irq event stamp: 302470
hardirqs last  enabled at (302469): [<c0104391>] syscall_exit_work+0x11/0x26
hardirqs last disabled at (302470): [<c0104119>] ret_from_exception+0x9/0xc
softirqs last  enabled at (301928): [<c0128e58>] __do_softirq+0xe4/0xea
softirqs last disabled at (301921): [<c0128e97>] do_softirq+0x39/0x55
oprofile: using NMI interrupt.
printk: 6 messages suppressed.
BUG: using smp_processor_id() in preemptible [00000001] code: mount/27913
caller is avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c0213313>] debug_smp_processor_id+0xb3/0xc8
 [<c0116a26>] avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
 [<fdc819b9>] nmi_create_files+0x2a/0x10e [oprofile]
 [<fdc80f52>] oprofile_create_files+0xe6/0xec [oprofile]
 [<fdc81157>] oprofilefs_fill_super+0x78/0x7e [oprofile]
 [<c0182d2e>] get_sb_single+0x59/0x9f
 [<fdc8108f>] oprofilefs_get_sb+0x1c/0x1e [oprofile]
 [<c0182792>] vfs_kern_mount+0x81/0xf1
 [<c0182852>] do_kern_mount+0x38/0xde
 [<c0196671>] do_mount+0x605/0x693
 [<c019677f>] sys_mount+0x80/0xb5
 [<c0104270>] syscall_call+0x7/0xb
 =======================
BUG: using smp_processor_id() in preemptible [00000001] code: mount/27913
caller is avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c0213313>] debug_smp_processor_id+0xb3/0xc8
 [<c0116a26>] avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
 [<fdc819b9>] nmi_create_files+0x2a/0x10e [oprofile]
 [<fdc80f52>] oprofile_create_files+0xe6/0xec [oprofile]
 [<fdc81157>] oprofilefs_fill_super+0x78/0x7e [oprofile]
 [<c0182d2e>] get_sb_single+0x59/0x9f
 [<fdc8108f>] oprofilefs_get_sb+0x1c/0x1e [oprofile]
 [<c0182792>] vfs_kern_mount+0x81/0xf1
 [<c0182852>] do_kern_mount+0x38/0xde
 [<c0196671>] do_mount+0x605/0x693
 [<c019677f>] sys_mount+0x80/0xb5
 [<c0104270>] syscall_call+0x7/0xb
 =======================
BUG: using smp_processor_id() in preemptible [00000001] code: mount/27913
caller is avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c0213313>] debug_smp_processor_id+0xb3/0xc8
 [<c0116a26>] avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
 [<fdc819b9>] nmi_create_files+0x2a/0x10e [oprofile]
 [<fdc80f52>] oprofile_create_files+0xe6/0xec [oprofile]
 [<fdc81157>] oprofilefs_fill_super+0x78/0x7e [oprofile]
 [<c0182d2e>] get_sb_single+0x59/0x9f
 [<fdc8108f>] oprofilefs_get_sb+0x1c/0x1e [oprofile]
 [<c0182792>] vfs_kern_mount+0x81/0xf1
 [<c0182852>] do_kern_mount+0x38/0xde
 [<c0196671>] do_mount+0x605/0x693
 [<c019677f>] sys_mount+0x80/0xb5
 [<c0104270>] syscall_call+0x7/0xb
 =======================
BUG: using smp_processor_id() in preemptible [00000001] code: mount/27913
caller is avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
 [<c0105256>] show_trace_log_lvl+0x1a/0x2f
 [<c010597b>] show_trace+0x12/0x14
 [<c0105a3d>] dump_stack+0x16/0x18
 [<c0213313>] debug_smp_processor_id+0xb3/0xc8
 [<c0116a26>] avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
 [<fdc819b9>] nmi_create_files+0x2a/0x10e [oprofile]
 [<fdc80f52>] oprofile_create_files+0xe6/0xec [oprofile]
 [<fdc81157>] oprofilefs_fill_super+0x78/0x7e [oprofile]
 [<c0182d2e>] get_sb_single+0x59/0x9f
 [<fdc8108f>] oprofilefs_get_sb+0x1c/0x1e [oprofile]
 [<c0182792>] vfs_kern_mount+0x81/0xf1
 [<c0182852>] do_kern_mount+0x38/0xde
 [<c0196671>] do_mount+0x605/0x693
 [<c019677f>] sys_mount+0x80/0xb5
 [<c0104270>] syscall_call+0x7/0xb
 =======================
SELinux: initialized (dev oprofilefs, type oprofilefs), uses genfs_contexts

l *avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
0xc01169fb is in avail_to_resrv_perfctr_nmi_bit (arch/i386/kernel/nmi.c:124).
119             return 0;
120     }
121
122     /* checks for a bit availability (hack for oprofile) */
123     int avail_to_resrv_perfctr_nmi_bit(unsigned int counter)
124     {
125             BUG_ON(counter > NMI_MAX_COUNTER_BITS);
126
127             return (!test_bit(counter, &__get_cpu_var(perfctr_nmi_owner)));
128     }

quilt patches arch/i386/kernel/nmi.c
x86_64-mm-i386-make-nmi-use-perfctr1-for-architectural-perfmon-take-2.patch

http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/broken-out-2007-03-18-02-44/mm-config

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Michal Piotrowski]

On 20/03/07, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> Andrew Morton wrote:
> > On Tue, 20 Mar 2007 13:47:53 +1100 Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> >
> >
> >>Andrew Morton wrote:
> >>
>
> >>Hang on a sec... I'll try fixing the thing before you next make a
> >>release.
> >>
> >
> >
> > Too late.  hot-fixes/ awaits thee.
>
> Awww... well thanks very much Michal for reporting the bug, I reproduced
> it easily and it turns out to be a typo.
>
> In my testing I never had a lot of writeout going on, so most of the pages
> will have been truncated in the first loop...
>

Problem fixed. Thanks!

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Sam Ravnborg]

On Mon, Mar 19, 2007 at 04:25:29PM -0700, Andrew Morton wrote:
> On Sun, 18 Mar 2007 19:35:48 +0100
> Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
> 
> > WARNING: could not find versions for .tmp_versions/built-in.mod
> > WARNING: could not find versions for .tmp_versions/built-in.mod
> > WARNING: could not find versions for .tmp_versions/built-in.mod
> > WARNING: could not find versions for .tmp_versions/built-in.mod
> > WARNING: could not find versions for .tmp_versions/built-in.mod
> > WARNING: could not find versions for .tmp_versions/built-in.mod
> 
> This is caused by git-kbuild.  I don't know what the significance of it is.

This is caused by the patch that runs modpost on all files
used to make up vmlinux.
The warning is harmless and I will try to fix it up tonight or tomorrow.

	Sam

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Andrew Morton]

On Tue, 20 Mar 2007 08:17:13 +0100 Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:

> akpm@linux-foundation.org napisał(a):
> > The mm snapshot broken-out-2007-03-18-02-44.tar.gz has been uploaded to
> > 
> >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-18-02-44.tar.gz
> > 
> > It contains the following patches against 2.6.21-rc4:
> 
> PM: Adding info for No Bus:vcsa7
> BUG: at kernel/lockdep.c:2430 check_flags()
>  [<c0105256>] show_trace_log_lvl+0x1a/0x2f
>  [<c010597b>] show_trace+0x12/0x14
>  [<c0105a3d>] dump_stack+0x16/0x18
>  [<c013e1b5>] check_flags+0xb7/0x187
>  [<c01413ea>] lock_acquire+0x3a/0x93
>  [<c0139a64>] down_write+0x3a/0x54
>  [<c0170563>] sys_munmap+0x23/0x3f
>  [<c0104270>] syscall_call+0x7/0xb
>  =======================
> irq event stamp: 302470
> hardirqs last  enabled at (302469): [<c0104391>] syscall_exit_work+0x11/0x26
> hardirqs last disabled at (302470): [<c0104119>] ret_from_exception+0x9/0xc
> softirqs last  enabled at (301928): [<c0128e58>] __do_softirq+0xe4/0xea
> softirqs last disabled at (301921): [<c0128e97>] do_softirq+0x39/0x55
> oprofile: using NMI interrupt.
> printk: 6 messages suppressed.

Don't know.  Several people seem to be hitting this.


> BUG: using smp_processor_id() in preemptible [00000001] code: mount/27913
> caller is avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
>  [<c0105256>] show_trace_log_lvl+0x1a/0x2f
>  [<c010597b>] show_trace+0x12/0x14
>  [<c0105a3d>] dump_stack+0x16/0x18
>  [<c0213313>] debug_smp_processor_id+0xb3/0xc8
>  [<c0116a26>] avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
>  [<fdc819b9>] nmi_create_files+0x2a/0x10e [oprofile]
>  [<fdc80f52>] oprofile_create_files+0xe6/0xec [oprofile]
>  [<fdc81157>] oprofilefs_fill_super+0x78/0x7e [oprofile]
>  [<c0182d2e>] get_sb_single+0x59/0x9f
>  [<fdc8108f>] oprofilefs_get_sb+0x1c/0x1e [oprofile]
>  [<c0182792>] vfs_kern_mount+0x81/0xf1
>  [<c0182852>] do_kern_mount+0x38/0xde
>  [<c0196671>] do_mount+0x605/0x693
>  [<c019677f>] sys_mount+0x80/0xb5
>  [<c0104270>] syscall_call+0x7/0xb
>  =======================

Odd.  It looks like oprofile has been doing this for some time.  Andi,
there are a few changes in the NMI area - can you think of one whihc would
have triggered this?

Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Andi Kleen]

On Tue, Mar 20, 2007 at 08:36:27AM -0800, Andrew Morton wrote:
> > caller is avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
> >  [<c0105256>] show_trace_log_lvl+0x1a/0x2f
> >  [<c010597b>] show_trace+0x12/0x14
> >  [<c0105a3d>] dump_stack+0x16/0x18
> >  [<c0213313>] debug_smp_processor_id+0xb3/0xc8
> >  [<c0116a26>] avail_to_resrv_perfctr_nmi_bit+0x2b/0x43
> >  [<fdc819b9>] nmi_create_files+0x2a/0x10e [oprofile]
> >  [<fdc80f52>] oprofile_create_files+0xe6/0xec [oprofile]
> >  [<fdc81157>] oprofilefs_fill_super+0x78/0x7e [oprofile]
> >  [<c0182d2e>] get_sb_single+0x59/0x9f
> >  [<fdc8108f>] oprofilefs_get_sb+0x1c/0x1e [oprofile]
> >  [<c0182792>] vfs_kern_mount+0x81/0xf1
> >  [<c0182852>] do_kern_mount+0x38/0xde
> >  [<c0196671>] do_mount+0x605/0x693
> >  [<c019677f>] sys_mount+0x80/0xb5
> >  [<c0104270>] syscall_call+0x7/0xb
> >  =======================
> 
> Odd.  It looks like oprofile has been doing this for some time.  Andi,
> there are a few changes in the NMI area - can you think of one whihc would
> have triggered this?

Looks like it was always broken. avail_to_resrv_perfctr_nmi_bit() must 
always do all this for all possible CPUs, not just the current one.
I can cook up a patch.

-Andi