LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jaya Kumar" <jayakumar.lkml@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: armbru@redhat.com, linux-kernel@vger.kernel.org,
	virtualization@lists.osdl.org, xen-devel@lists.xensource.com,
	linux-fbdev-devel@lists.sourceforge.net, adaplas@pol.net,
	linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized
Date: Thu, 20 Mar 2008 06:55:11 +0800	[thread overview]
Message-ID: <45a44e480803191555vfcfe493r4f2fd267097d9a38@mail.gmail.com> (raw)
In-Reply-To: <20080319153946.a5a8060e.akpm@linux-foundation.org>

On Thu, Mar 20, 2008 at 6:39 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
>  Well all we have in the changelog is
>
>   Implement support for the E-Ink Metronome controller.  It provides an
>   mmapable interface to the controller using defio support.  It was tested
>   with a gumstix pxa255 with Vizplex media using Xfbdev and various X
>   clients such as xeyes, xpdf, xloadimage.
>
>  grump.  This say nothing at all about the change to drivers/video/fb_defio.c.

I apologize. I should have done better.

>
>  a) the changelog _should_ document this change.  Please send a paragraph and
>    I'll add it.

This patch fixes the following bug. Defio would cause a hang on write
access to the framebuffer as the page fault would be called
ad-infinitum. It fixes fb_defio by setting the mapping to be used by
page_mkclean.

>
>  b) If this discussion hadn't happened, that bug (whatever it is) would
>    have remained unfixed in 2.6.25.  As a direct consequence of poor
>    changelogging.

Understood. The root cause of my flaw was my assumption that other
than me, there weren't any users of defio so I was in no hurry to get
it fixed.

>
>  c) This bugfix (whatever it is) should have been in a separate patch.

Understood. It won't happen again.

Thanks,
jaya

  reply	other threads:[~2008-03-20  0:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 13:00 [PATCH 0/3] xen pvfb: Para-virtual framebuffer, keyboard and pointer Markus Armbruster
2008-02-25 13:02 ` [PATCH 1/3] xen: Make xen-blkfront write its protocol ABI to xenstore Markus Armbruster
2008-02-25 13:03 ` [PATCH 2/3] fbdev: Make deferred I/O work as advertized Markus Armbruster
2008-02-26 14:11   ` Jaya Kumar
2008-02-26 14:45     ` Markus Armbruster
2008-02-26 15:01       ` Jaya Kumar
2008-03-19 10:45         ` Markus Armbruster
2008-03-19 11:24           ` Jaya Kumar
2008-03-19 18:37             ` Andrew Morton
2008-03-19 22:30               ` Jaya Kumar
2008-03-19 22:39                 ` Andrew Morton
2008-03-19 22:55                   ` Jaya Kumar [this message]
2008-02-25 13:06 ` [PATCH 3/3] xen pvfb: Para-virtual framebuffer, keyboard and pointer driver Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45a44e480803191555vfcfe493r4f2fd267097d9a38@mail.gmail.com \
    --to=jayakumar.lkml@gmail.com \
    --cc=adaplas@pol.net \
    --cc=akpm@linux-foundation.org \
    --cc=armbru@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    --cc=xen-devel@lists.xensource.com \
    --subject='Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).