LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Subhash Jadavani <subhashj@codeaurora.org>
To: Asutosh Das <asutoshd@codeaurora.org>
Cc: cang@codeaurora.org, vivek.gautam@codeaurora.org,
	rnayak@codeaurora.org, vinholikatti@gmail.com,
	jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
	linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Venkat Gopalakrishnan <venkatg@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH v2 05/10] scsi: ufshcd: fix possible unclocked register access
Date: Wed, 16 May 2018 14:12:33 -0700	[thread overview]
Message-ID: <45d251138fac73f4776eae34d9e36def@codeaurora.org> (raw)
In-Reply-To: <7f237069f86547afedcbbdf673cf85dfb20d05fa.1525343531.git.asutoshd@codeaurora.org>

On 2018-05-03 04:07, Asutosh Das wrote:
> From: Subhash Jadavani <subhashj@codeaurora.org>
> 
> vendor specific setup_clocks ops may depend on clocks managed by ufshcd
> driver so if the vendor specific setup_clocks callback is called when
> the required clocks are turned off, it results into unclocked register
> access.
> 
> This change make sure that required clocks are enabled before vendor
> specific setup_clocks callback is called.
> 
> Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
> Signed-off-by: Venkat Gopalakrishnan <venkatg@codeaurora.org>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> ---
>  drivers/scsi/ufs/ufshcd.c | 26 ++++++++++++++++++++------
>  1 file changed, 20 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 838ba8f0..dfeb194 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6780,9 +6780,16 @@ static int __ufshcd_setup_clocks(struct ufs_hba
> *hba, bool on,
>  	if (list_empty(head))
>  		goto out;
> 
> -	ret = ufshcd_vops_setup_clocks(hba, on, PRE_CHANGE);
> -	if (ret)
> -		return ret;
> +	/*
> +	 * vendor specific setup_clocks ops may depend on clocks managed by
> +	 * this standard driver hence call the vendor specific setup_clocks
> +	 * before disabling the clocks managed here.
> +	 */
> +	if (!on) {
> +		ret = ufshcd_vops_setup_clocks(hba, on, PRE_CHANGE);
> +		if (ret)
> +			return ret;
> +	}
> 
>  	list_for_each_entry(clki, head, list) {
>  		if (!IS_ERR_OR_NULL(clki->clk)) {
> @@ -6806,9 +6813,16 @@ static int __ufshcd_setup_clocks(struct ufs_hba
> *hba, bool on,
>  		}
>  	}
> 
> -	ret = ufshcd_vops_setup_clocks(hba, on, POST_CHANGE);
> -	if (ret)
> -		return ret;
> +	/*
> +	 * vendor specific setup_clocks ops may depend on clocks managed by
> +	 * this standard driver hence call the vendor specific setup_clocks
> +	 * after enabling the clocks managed here.
> +	 */
> +	if (on) {
> +		ret = ufshcd_vops_setup_clocks(hba, on, POST_CHANGE);
> +		if (ret)
> +			return ret;
> +	}
> 
>  out:
>  	if (ret) {

Looks good to me.

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2018-05-16 21:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1525341340.git.asutoshd@codeaurora.org>
     [not found] ` <cover.1525343531.git.asutoshd@codeaurora.org>
2018-05-03 11:07   ` [PATCH v2 01/10] scsi: ufs: Allowing power mode change Asutosh Das
2018-05-16 21:09     ` Subhash Jadavani
2018-05-03 11:07   ` [PATCH v2 02/10] scsi: ufs-qcom: Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk Asutosh Das
2018-05-16 21:10     ` Subhash Jadavani
2018-05-03 11:07   ` [PATCH v2 03/10] scsi: ufs: Add LCC quirk for host and device Asutosh Das
2018-05-16 21:11     ` Subhash Jadavani
2018-05-03 11:07   ` [PATCH v2 04/10] scsi: ufs: fix exception event handling Asutosh Das
2018-05-16 21:12     ` Subhash Jadavani
2018-05-03 11:07   ` [PATCH v2 05/10] scsi: ufshcd: fix possible unclocked register access Asutosh Das
2018-05-16 21:12     ` Subhash Jadavani [this message]
2018-05-03 11:07   ` [PATCH v2 06/10] scsi: ufs: add reference counting for scsi block requests Asutosh Das
2018-05-16 21:13     ` Subhash Jadavani
2018-05-03 11:07   ` [PATCH v2 07/10] scsi: ufs-qcom: remove broken hci version quirk Asutosh Das
2018-05-16 21:13     ` Subhash Jadavani
2018-05-03 11:07   ` [PATCH v2 08/10] scsi: ufs: make sure all interrupts are processed Asutosh Das
2018-05-16 21:14     ` Subhash Jadavani
2018-05-03 11:07   ` [PATCH v2 09/10] scsi: ufs: fix irq return code Asutosh Das
2018-06-28 22:26     ` Subhash Jadavani
2018-05-03 11:07   ` [PATCH v2 10/10] scsi: ufs: Add clock ungating to a separate workqueue Asutosh Das
2018-05-16 21:14     ` Subhash Jadavani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45d251138fac73f4776eae34d9e36def@codeaurora.org \
    --to=subhashj@codeaurora.org \
    --cc=asutoshd@codeaurora.org \
    --cc=cang@codeaurora.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=rnayak@codeaurora.org \
    --cc=venkatg@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    --cc=vivek.gautam@codeaurora.org \
    --subject='Re: [PATCH v2 05/10] scsi: ufshcd: fix possible unclocked register access' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).