LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Avi Kivity <avi@qumranet.com>, Andrew Morton <akpm@osdl.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@muc.de>
Subject: Re: [PATCH] Cleanup: rationalize paravirt wrappers
Date: Thu, 22 Mar 2007 01:09:32 -0700	[thread overview]
Message-ID: <460239BC.4070500@goop.org> (raw)
In-Reply-To: <1174550442.2713.128.camel@localhost.localdomain>

Rusty Russell wrote:
> The behaviour change (don't oops when an invalid rdmsr is used) was
> there with CONFIG_PARAVIRT=y, the cleanup just made !CONFIG_PARAVIRT the
> same.  Is it important?
>   

We could always fling a BUG_ON in the non-safe versions, which would
probably be more informative than a GPF or whatever a bad MSR gives you.

    J

  reply	other threads:[~2007-03-22  8:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22  2:41 Rusty Russell
2007-03-22  7:30 ` Avi Kivity
2007-03-22  8:00   ` Rusty Russell
2007-03-22  8:09     ` Jeremy Fitzhardinge [this message]
2007-03-22  8:09     ` Avi Kivity
2007-03-22  9:55       ` Rusty Russell
2007-03-23 11:05 ` Rusty Russell
2007-03-23 11:19   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460239BC.4070500@goop.org \
    --to=jeremy@goop.org \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=avi@qumranet.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --subject='Re: [PATCH] Cleanup: rationalize paravirt wrappers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).