LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bruce Dubbs <bruce.dubbs@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Possible Bug in mincore or mmap
Date: Thu, 22 Mar 2007 14:20:29 -0500 [thread overview]
Message-ID: <4602D6FD.6030505@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]
When testing an installation with tests from the Linux Test Project, my
kernels fail one instance of the mincore01 tests:
mincoremincore01 1 PASS : expected failure: errno = 22 (Invalid
argument)
mincore01 2 PASS : expected failure: errno = 14 (Bad address)
mincore01 3 FAIL : call succeeded unexpectedly
mincore01 4 PASS : expected failure: errno = 12 (Cannot allocate
memory)01 1 PASS : expected failure: errno = 22 (Invalid argument)
mincore01 2 PASS : expected failure: errno = 14 (Bad address)
mincore01 3 FAIL : call succeeded unexpectedly
mincore01 4 PASS : expected failure: errno = 12 (Cannot allocate
memory)
I pared down the test to the attached program. The result is supposed
to fail as it is asking for memory information 5 times what should be
allocated.
Upon experimenting, I found the test works properly if a printf is
executed before the mmap call. I have tested on locally built, but
unmodified, 2.4.25, 2.6.12.5, and a 2.6.20.3 kernels and get the same
behavior. The tests fail on IA32 architecture, but not 64-bit kernels.
The test always works properly on FC6 and RHEL3.
I've checked the archives for this issue and could not find anything
appropriate.
Could this be a potential security issue as memory that is not supposed
to be accessible seems to be available to the user? Is it expected
behavior?
Thanks.
-- Bruce
[-- Attachment #2: min.c --]
[-- Type: text/plain, Size: 1747 bytes --]
#include <sys/mman.h>
#include <stdlib.h>
#include <string.h>
#include <stdio.h>
static int PAGESIZE;
static char file_name[] = "fooXXXXXX";
static void* global_pointer = NULL;
static int global_len = 0;
static int file_desc = 0;
int main(int argc, char **argv)
{
int i;
int result;
char* buf;
unsigned char vect[20] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
PAGESIZE = getpagesize();
/* global_pointer will point to a mmapped area of global_len bytes */
global_len = PAGESIZE*2;
buf = (char*)malloc(global_len);
memset(buf, 42, global_len); // Asterisks
/* create a temporary file */
file_desc = mkstemp(file_name);
/* fill the temporary file with two pages of data */
write(file_desc, buf, global_len);
free(buf);
// Will work properly as long as print is before mmap function.
if ( argc > 1 ) printf("argc=%d\n", argc);
/* map the file in memory */
global_pointer = mmap( NULL, global_len,
PROT_READ|PROT_WRITE|PROT_EXEC, MAP_SHARED, file_desc, 0);
// Result should be -1 as the request is 5 times actual mapping
result = mincore(global_pointer, (size_t)(global_len*5), vect);
// Print some data
printf("PAGESIZE=%d\n", PAGESIZE);
printf("global_len=%d\n", global_len);
printf("global_pointer=0x%x\n", (unsigned int)global_pointer);
printf("alloc=%d\n", (global_len+PAGESIZE-1) / PAGESIZE );
printf("Result=%d\n", result);
printf("vect: ");
for ( i=0; i<20; i++) printf("%02x ", vect[i]);
printf("\n");
// Clean up
munmap(global_pointer, (size_t)global_len);
close(file_desc);
unlink(file_name);
}
next reply other threads:[~2007-03-22 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 19:20 Bruce Dubbs [this message]
2007-03-23 0:52 ` Nick Piggin
2007-03-23 2:50 ` Bruce Dubbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4602D6FD.6030505@gmail.com \
--to=bruce.dubbs@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: Possible Bug in mincore or mmap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).