LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] make KVM conform to sucky rdmsr interface
@ 2007-03-22  2:51 Rusty Russell
  2007-03-22  7:20 ` Avi Kivity
  0 siblings, 1 reply; 7+ messages in thread
From: Rusty Russell @ 2007-03-22  2:51 UTC (permalink / raw)
  To: Andi Kleen, Avi Kivity, Andrew Morton
  Cc: lkml - Kernel Mailing List, kvm-devel

Grrr.... Andi refused to take my "rdmsr64" patch which moved to a
function-like interface for MSRs, dismissing it as pointless churn.

paravirt_ops cleanups changed a macro to an inline and spotted this
kvm bug.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff -r 47c6ee74a5c5 drivers/kvm/vmx.c
--- a/drivers/kvm/vmx.c	Thu Mar 22 12:57:44 2007 +1100
+++ b/drivers/kvm/vmx.c	Thu Mar 22 13:38:24 2007 +1100
@@ -1127,7 +1127,7 @@ static int vmx_vcpu_setup(struct kvm_vcp
 		u64 data;
 		int j = vcpu->nmsrs;
 
-		if (rdmsr_safe(index, &data_low, &data_high) < 0)
+		if (rdmsr_safe(index, data_low, data_high) < 0)
 			continue;
 		if (wrmsr_safe(index, data_low, data_high) < 0)
 			continue;



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2007-03-23  1:11 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-22  2:51 [PATCH] make KVM conform to sucky rdmsr interface Rusty Russell
2007-03-22  7:20 ` Avi Kivity
2007-03-22  7:49   ` Rusty Russell
2007-03-22  7:55     ` Jeremy Fitzhardinge
2007-03-22 21:30     ` Andrew Morton
2007-03-22 22:01       ` Jeremy Fitzhardinge
2007-03-23  1:10       ` Rusty Russell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).