From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbXC3JOZ (ORCPT ); Fri, 30 Mar 2007 05:14:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753852AbXC3JOZ (ORCPT ); Fri, 30 Mar 2007 05:14:25 -0400 Received: from public.id2-vpn.continvity.gns.novell.com ([195.33.99.129]:39758 "EHLO public.id2-vpn.continvity.gns.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753094AbXC3JOZ (ORCPT ); Fri, 30 Mar 2007 05:14:25 -0400 Message-Id: <460CF131.76E4.0078.0@novell.com> X-Mailer: Novell GroupWise Internet Agent 7.0.1 Date: Fri, 30 Mar 2007 10:14:57 +0100 From: "Jan Beulich" To: "Randy Dunlap" Cc: , Subject: Re: [PATCH] fix dependency generation References: <460BA292.76E4.0078.0@novell.com><20070329083947.d9ba87e0.randy.dunlap@oracle.com><460C0020.76E4.0078.0@novell.com> <20070329093838.d5b2d88a.randy.dunlap@oracle.com> In-Reply-To: <20070329093838.d5b2d88a.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >>> Randy Dunlap 29.03.07 18:38 >>> >On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote: > >> >>> Randy Dunlap 29.03.07 17:39 >>> >> >> --- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.000000000 +0100 >> >> +++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c 2007-03-29 11:11:10.000000000 +0200 >> >> @@ -29,8 +29,7 @@ >> >> * option which is mentioned in any of the listed prequisites. >> >> * >> >> * To be exact, split-include populates a tree in include/config/, >> >> - * e.g. include/config/his/driver.h, which contains the #define/#undef >> >> - * for the CONFIG_HIS_DRIVER option. >> > >> >I don't see why you deleted the line above. >> >> Because it is no longer true. These files are empty as of 2.6.18. > >We seem to be talking about different lines above. Yes, the files >are empty, but they are named based on the CONFIG_symbol name, which >is what I was trying to get at. So how about a comment like this: > > * To be exact, split-include populates a tree in include/config/, > * e.g., include/config/sysctl/syscall.h, > * for the CONFIG_SYSCTL_SYSCALL option, when that option > * is enabled (=y or =m). Shouldn't that then be '..., when that option is or ever was enabled (=y or =m) since last cleaning the tree'? Jan