LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Zachary Amsden <zach@vmware.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, Andi Kleen <ak@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i386: For debugging, make the initial page table setup less forgiving.
Date: Fri, 13 Apr 2007 15:40:27 -0700	[thread overview]
Message-ID: <462006DB.5070308@vmware.com> (raw)
In-Reply-To: <4620038B.5020700@zytor.com>

H. Peter Anvin wrote:
> Zachary Amsden wrote:
>> H. Peter Anvin wrote:
>>> +    /*
>>> +     * End condition: we must map up to and including
>>> +     * INIT_MAP_BEYOND_END bytes beyond the end of our
>>> +     * own page tables; 0x1000 is the size of the page
>>> +     * table were about to write, and +0x007 is the
>>> +     * attribute bits.
>>> +     */
>>> +    leal (INIT_MAP_BEYOND_END+0x1000+0x007)(%edi),%ebp
>>>   
>>
>> hrmm?  Shouldn't that still be INIT_MAP_BEYOND_END+0x0007?  Seems you 
>> are mapping 4M more than you need.
>>
>
> 4K, not 4M.  This is an actual address, not an indirection.

Ok, the old code was writing the entire page table, so it was mapping up 
4M more than it should have.  It wasn't clear with 10b out of scope in 
the patch.

>
> However, the expression is correct, because it needs to refer to the 
> termination address *after* the current page table is written -- you 
> can think of it as having already allocated 4K for a page table that 
> it is about to be generated.

Correct.

Acked-by: Zachary Amsden <zach@vmware.com>

  reply	other threads:[~2007-04-13 22:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-13 21:49 H. Peter Anvin
2007-04-13 22:18 ` Zachary Amsden
2007-04-13 22:26   ` H. Peter Anvin
2007-04-13 22:40     ` Zachary Amsden [this message]
2007-04-13 22:26   ` Jeremy Fitzhardinge
2007-04-25 11:48 ` Andrew Morton
2007-04-25 15:28   ` H. Peter Anvin
2007-04-25 17:50     ` Eric W. Biederman
2007-04-25 17:56       ` H. Peter Anvin
2007-04-25 18:23         ` Eric W. Biederman
2007-04-25 18:18       ` Jeremy Fitzhardinge
2007-04-25 19:01         ` Eric W. Biederman
2007-04-25 19:19           ` Jeremy Fitzhardinge
2007-04-25 22:08           ` Jeremy Fitzhardinge
2007-04-25 22:27             ` Eric W. Biederman
2007-04-25 23:08               ` Jeremy Fitzhardinge
2007-04-25 23:45                 ` Eric W. Biederman
2007-04-26  0:14                   ` Jeremy Fitzhardinge
2007-04-27  5:02                     ` Eric W. Biederman
2007-04-26  3:27                   ` Zachary Amsden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462006DB.5070308@vmware.com \
    --to=zach@vmware.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] i386: For debugging, make the initial page table setup less forgiving.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).