LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>, Zachary Amsden <zach@vmware.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i386: For debugging, make the initial page table setup less forgiving.
Date: Wed, 25 Apr 2007 12:19:25 -0700	[thread overview]
Message-ID: <462FA9BD.5020000@goop.org> (raw)
In-Reply-To: <m1wt00qnwg.fsf@ebiederm.dsl.xmission.com>

Eric W. Biederman wrote:
>> Hm, but it should be overwriting small mappings with large ones.  Maybe
>> I overlooked that.
>>     
>
> Nope.  It's not overwriting anything.

It will work if we just overwrite the pmd's with large pages in the PSE
case, since Xen doesn't support PSE.  Or we could only overwrite if its
!present or !huge.

>   I'm not at all convinced we
> should preserve the Xen sillyness.  I'm not exactly against it,
> but it adds complexity to already complex code.
>   

Yes.  I would love to see that code get simplified.  I've been trying to
walk a line of making my changes small and incremental, while still
trying to get a reasonable result.  In this case, its a file which has
undergone many such changes, and the entropy is really building up.

The Xen case is tricky because the hypervisor is very strict about what
can be in the pagetable, and so we can't go through any transitional bad
states on the way to constructing the final result.  The easiest way to
do that is use the existing pagetable where possible and just add new
things to it.

> We will have to see.  Currently the paravirt pagetable setup clashes
> horrible with actually running a kernel on real hardware.
>   

I'll fix it up.  I've been running these kernels on my normal work
machine without obvious problems, which is why it escaped notice until
HPA's debug patch.

> Color me not impressed by the paravirt mess.

Well, I'm working on it :)

    J


  reply	other threads:[~2007-04-25 19:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-13 21:49 H. Peter Anvin
2007-04-13 22:18 ` Zachary Amsden
2007-04-13 22:26   ` H. Peter Anvin
2007-04-13 22:40     ` Zachary Amsden
2007-04-13 22:26   ` Jeremy Fitzhardinge
2007-04-25 11:48 ` Andrew Morton
2007-04-25 15:28   ` H. Peter Anvin
2007-04-25 17:50     ` Eric W. Biederman
2007-04-25 17:56       ` H. Peter Anvin
2007-04-25 18:23         ` Eric W. Biederman
2007-04-25 18:18       ` Jeremy Fitzhardinge
2007-04-25 19:01         ` Eric W. Biederman
2007-04-25 19:19           ` Jeremy Fitzhardinge [this message]
2007-04-25 22:08           ` Jeremy Fitzhardinge
2007-04-25 22:27             ` Eric W. Biederman
2007-04-25 23:08               ` Jeremy Fitzhardinge
2007-04-25 23:45                 ` Eric W. Biederman
2007-04-26  0:14                   ` Jeremy Fitzhardinge
2007-04-27  5:02                     ` Eric W. Biederman
2007-04-26  3:27                   ` Zachary Amsden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462FA9BD.5020000@goop.org \
    --to=jeremy@goop.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zach@vmware.com \
    --subject='Re: [PATCH] i386: For debugging, make the initial page table setup less forgiving.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).