LKML Archive on
help / color / mirror / Atom feed
From: Paul Fulghum <>
To: Arnd Bergmann <>
Cc: Andrew Morton <>,
	Linux Kernel Mailing List <>,
	"Eric W. Biederman" <>,
	Alan Cox <>,
	Peter Zijlstra <>
Subject: Re: [PATCH] tty add compat_ioctl
Date: Thu, 03 May 2007 21:05:25 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Paul Fulghum wrote:
> Arnd Bergmann wrote:
>> - In your driver you don't get the big kernel lock in the 
>> compat_ioctl function. I assume that this is correct for
>> the particular driver, but it may be nice if you could
>> consequently also add an unlocked_ioctl function that can
>> be used without the BKL for native ioctls. It would be good
>> to hear an opinon on this from someone who has an insight
>> in tty locking issues though, so I'm Cc:ing some people
>> who have touched that recently.
> I don't count on higher level locking for
> synchronization issues specific to the driver.
> I thought the current compat_ioctl() was already
> meant to *not* have the BKL just like unlocked_ioctl.
> My thought was that any driver getting a recent update
> like compat_ioctl() would need to be reviewed for BKL
> safety and take the lock manually if necessary.

Nevermind. I misread what you wrote (I'm tired).
Yes, adding an unlocked_ioctl() makes sense.


  reply	other threads:[~2007-05-04  2:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03 17:34 Paul Fulghum
     [not found] ` <>
2007-05-04  1:44   ` Paul Fulghum
2007-05-04  3:05     ` Paul Fulghum [this message]
2007-05-04 21:11   ` Paul Fulghum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] tty add compat_ioctl' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).