LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Michal Rostecki <mrostecki@opensuse.org>
Cc: Shuah Khan <shuah@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	Martin Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <jakub.kicinski@netronome.com>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	"open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>,
	"open list:BPF (Safe dynamic programs and tools)" 
	<netdev@vger.kernel.org>,
	"open list:BPF (Safe dynamic programs and tools)" 
	<bpf@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>,
	"open list:XDP (eXpress Data Path)" <xdp-newbies@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 RESEND 0/2] Move bpf_printk to bpf_helpers.h
Date: Thu, 23 May 2019 16:51:20 +0000	[thread overview]
Message-ID: <4642ca96-22ab-ad61-a6a1-1d2ef7239cb8@fb.com> (raw)
In-Reply-To: <20190523125355.18437-1-mrostecki@opensuse.org>



On 5/23/19 5:53 AM, Michal Rostecki wrote:
> This series of patches move the commonly used bpf_printk macro to
> bpf_helpers.h which is already included in all BPF programs which
> defined that macro on their own.
> 
> v1->v2:
> - If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set
>    an empty macro for it.
> 
> Michal Rostecki (2):
>    selftests: bpf: Move bpf_printk to bpf_helpers.h
>    samples: bpf: Do not define bpf_printk macro
> 
>   samples/bpf/hbm_kern.h                                | 11 ++---------
>   samples/bpf/tcp_basertt_kern.c                        |  7 -------
>   samples/bpf/tcp_bufs_kern.c                           |  7 -------
>   samples/bpf/tcp_clamp_kern.c                          |  7 -------
>   samples/bpf/tcp_cong_kern.c                           |  7 -------
>   samples/bpf/tcp_iw_kern.c                             |  7 -------
>   samples/bpf/tcp_rwnd_kern.c                           |  7 -------
>   samples/bpf/tcp_synrto_kern.c                         |  7 -------
>   samples/bpf/tcp_tos_reflect_kern.c                    |  7 -------
>   samples/bpf/xdp_sample_pkts_kern.c                    |  7 -------
>   tools/testing/selftests/bpf/bpf_helpers.h             |  8 ++++++++
>   .../testing/selftests/bpf/progs/sockmap_parse_prog.c  |  7 -------
>   .../selftests/bpf/progs/sockmap_tcp_msg_prog.c        |  7 -------
>   .../selftests/bpf/progs/sockmap_verdict_prog.c        |  7 -------
>   .../testing/selftests/bpf/progs/test_lwt_seg6local.c  |  7 -------
>   tools/testing/selftests/bpf/progs/test_xdp_noinline.c |  7 -------
>   tools/testing/selftests/bpf/test_sockmap_kern.h       |  7 -------
>   17 files changed, 10 insertions(+), 114 deletions(-)

Ack for the whole series.
Acked-by: Yonghong Song <yhs@fb.com>

  parent reply	other threads:[~2019-05-23 17:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 12:53 Michal Rostecki
2019-05-23 12:53 ` [PATCH bpf-next v2 RESEND 1/2] selftests: bpf: " Michal Rostecki
2019-05-23 12:53 ` [PATCH bpf-next v2 RESEND 2/2] samples: bpf: Do not define bpf_printk macro Michal Rostecki
2019-05-23 16:51 ` Yonghong Song [this message]
2019-05-24 20:49   ` [PATCH bpf-next v2 RESEND 0/2] Move bpf_printk to bpf_helpers.h Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4642ca96-22ab-ad61-a6a1-1d2ef7239cb8@fb.com \
    --to=yhs@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=jakub.kicinski@netronome.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mrostecki@opensuse.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=xdp-newbies@vger.kernel.org \
    --subject='Re: [PATCH bpf-next v2 RESEND 0/2] Move bpf_printk to bpf_helpers.h' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).