LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: dean gaudet <dean@arctic.org>, Dave Dillow <dave@thedillows.org>
Cc: linux-ide@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH, RFT, v4] sata_mv: convert to new EH
Date: Sat, 26 May 2007 16:56:53 -0400	[thread overview]
Message-ID: <46589F15.8080003@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705252335590.8327@twinlark.arctic.org>

dean gaudet wrote:
> On Fri, 25 May 2007, Jeff Garzik wrote:
> 
>> Already uncovered and fixed a few bugs in v3.
>>
>> Here's v4 of the sata_mv new-EH patch.
> 
> you asked for test results with 2.6.21.3 ... that seems to boot fine,
> and i've tested reading from the disks only and it seems to be working
> fine.  ditto for 2.6.22-rc3.
> 
> but 2.6.22-rc3 + your v4 patch fails... i'll send you the serial console
> outputs offline.

Well, I have the same hardware as dean, and do not see the 
BUG_ON/WARN_ON traces that he sees.  These are the same two code 
locations that caused spewage before.  This only difference I see is 
that he is testing with an NCQ-capable disk, and I am not -- which could 
be a very significant difference.  Dave also appears to have an 
NCQ-capable disk.

Dave's output (sent privately to me) was different -- errors and 
corruption -- rather than the BUG_ON/WARN_ON stuff both he and dean sent 
in March 2007, which is interesting.

Dave, any chance you could try 2.6.22-rc3 + my v4 patch, on a different 
hard drive?  Preferably a non-Maxtor, or at least not another Maxtor 
6L200S0.  If that's a big deal, don't worry about it.  I just want to 
rule out buggy firmware and/or bad hard drive in your case.

dean's output (backtraces matching March 2007 reports) was what I 
expected, and if I can reproduce that with an NCQ-capable disk locally, 
I should be able to fix it from there without trouble.  Probably just 
some hardware bits accidentally kicking into NCQ mode, when they should not.

	Jeff






  reply	other threads:[~2007-05-26 20:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-25 23:34 [PATCH, RFT, v2] " Jeff Garzik
2007-03-02  0:54 ` Andre Tomt
2007-03-02  1:11   ` Jeff Garzik
     [not found] ` <1173158201.3416.8.camel@obelisk.thedillows.org>
     [not found]   ` <45ED039E.20608@garzik.org>
     [not found]     ` <1173164261.3416.15.camel@obelisk.thedillows.org>
2007-05-25 13:56       ` [PATCH, RFT, v3] " Jeff Garzik
2007-05-26  3:16         ` [PATCH, RFT, v4] " Jeff Garzik
2007-05-26  7:53           ` dean gaudet
2007-05-26 20:56             ` Jeff Garzik [this message]
2007-05-26 21:11               ` Dave Dillow
2007-05-26 21:38                 ` Jeff Garzik
2007-05-27  1:46                   ` Dave Dillow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46589F15.8080003@garzik.org \
    --to=jeff@garzik.org \
    --cc=dave@thedillows.org \
    --cc=dean@arctic.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH, RFT, v4] sata_mv: convert to new EH' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).