LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* jbd lost fix?
@ 2007-07-02 14:16 Kirill Korotaev
  2007-07-09 13:00 ` Jan Kara
  0 siblings, 1 reply; 3+ messages in thread
From: Kirill Korotaev @ 2007-07-02 14:16 UTC (permalink / raw)
  To: Jan Kara; +Cc: devel, Linux Kernel Mailing List, Mark Fasheh

Jan,

it looks like the following fix:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=43c3e6f5abdf6acac9b90c86bf03f995bf7d3d92

was lost after resurrecting of the spliced checkpointing list in this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=78ce89c92bc6eaf5933b5664bff64253a7103bd7;hp=cdaad343b561cdeb38b0578bb038

Can you please confirm that?

Thanks,
Kirill


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: jbd lost fix?
  2007-07-02 14:16 jbd lost fix? Kirill Korotaev
@ 2007-07-09 13:00 ` Jan Kara
  2007-07-09 14:26   ` Kirill Korotaev
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2007-07-09 13:00 UTC (permalink / raw)
  To: Kirill Korotaev; +Cc: devel, Linux Kernel Mailing List, Mark Fasheh

  Hello,

On Mon 02-07-07 18:16:09, Kirill Korotaev wrote:
> it looks like the following fix:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=43c3e6f5abdf6acac9b90c86bf03f995bf7d3d92
> 
> was lost after resurrecting of the spliced checkpointing list in this patch:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=78ce89c92bc6eaf5933b5664bff64253a7103bd7;hp=cdaad343b561cdeb38b0578bb038
> 
> Can you please confirm that?
  Sorry for a bit late reply but I was on holiday for a week. Yes, it seems
like that fix got lost. At least 2.6.22-rc5 still has a wrong test on line
890 in commit.c. Thanks for notification, I'll resend it.
  BTW: How have you found this out?

									Honza
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: jbd lost fix?
  2007-07-09 13:00 ` Jan Kara
@ 2007-07-09 14:26   ` Kirill Korotaev
  0 siblings, 0 replies; 3+ messages in thread
From: Kirill Korotaev @ 2007-07-09 14:26 UTC (permalink / raw)
  To: Jan Kara; +Cc: Kirill Korotaev, devel, Linux Kernel Mailing List, Mark Fasheh

Jan Kara wrote:
>   Hello,
> 
> On Mon 02-07-07 18:16:09, Kirill Korotaev wrote:
> 
>>it looks like the following fix:
>>http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=43c3e6f5abdf6acac9b90c86bf03f995bf7d3d92
>>
>>was lost after resurrecting of the spliced checkpointing list in this patch:
>>http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=78ce89c92bc6eaf5933b5664bff64253a7103bd7;hp=cdaad343b561cdeb38b0578bb038
>>
>>Can you please confirm that?
> 
>   Sorry for a bit late reply but I was on holiday for a week. Yes, it seems
> like that fix got lost. At least 2.6.22-rc5 still has a wrong test on line
> 890 in commit.c. Thanks for notification, I'll resend it.
>   BTW: How have you found this out?

One of OpenVZ users had an oops at journal_clean_one_cp_list+0x32/0x70
http://bugzilla.openvz.org/show_bug.cgi?id=605

which led us to the lost fix.
Since the patch existed before I didn't dare to resend it from OVZ name :)

Thanks,
Kirill



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-09 14:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-02 14:16 jbd lost fix? Kirill Korotaev
2007-07-09 13:00 ` Jan Kara
2007-07-09 14:26   ` Kirill Korotaev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).