Re: [PATCH][RESEND] efficeon-agp leaks 'struct agp_bridge_data' in error paths of agp_efficeon_probe()

Re: [PATCH][RESEND] efficeon-agp leaks 'struct agp_bridge_data' in error paths of agp_efficeon_probe()

[H. Peter Anvin]

Jesper Juhl wrote:
> (This is a resend of a patch originally submitted on 24-Jul-2007 00:14)
> 
> 
> Ok, this is something the coverity checker found (CID: 1813). 
> I'm not at all intimate with this code, so I'm not sure if this 
> attempt at a fix is correct (but at least it compiles).
> 
> Please look it over and NACK if bad or merge if good ;-)
> 

Looks sensible to me.

	-hpa

Re: [PATCH][RESEND] efficeon-agp leaks 'struct agp_bridge_data' in error paths of agp_efficeon_probe()

[Jesper Juhl]

On 05/08/07, H. Peter Anvin <hpa@zytor.com> wrote:
> Jesper Juhl wrote:
> > (This is a resend of a patch originally submitted on 24-Jul-2007 00:14)
> >
> >
> > Ok, this is something the coverity checker found (CID: 1813).
> > I'm not at all intimate with this code, so I'm not sure if this
> > attempt at a fix is correct (but at least it compiles).
> >
> > Please look it over and NACK if bad or merge if good ;-)
> >
>
> Looks sensible to me.
>
Good. Thank you for taking a look.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html