LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: trenn@suse.de
Cc: Ben Collins <bcollins@ubuntu.com>,
	"Brown, Len" <len.brown@intel.com>,
	linux-acpi@vger.kernel.org, Stelian Pop <stelian@popies.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sonypi: Fix initialization warning
Date: Sun, 05 Aug 2007 22:03:10 +0200	[thread overview]
Message-ID: <46B62CFE.2010404@student.ltu.se> (raw)
In-Reply-To: <1186343443.3858.46.camel@fanta4.site>

Thomas Renninger wrote:
> On Sun, 2007-08-05 at 21:05 +0200, Richard Knutsson wrote:
>   
>> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
>> ---
>> Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)):
>> drivers/char/sonypi.c:1153: warning: initialization from incompatible pointer type
>>
>>
>> diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c
>> index 73037a4..2dcd519 100644
>> --- a/drivers/char/sonypi.c
>> +++ b/drivers/char/sonypi.c
>> @@ -1147,10 +1147,15 @@ static int sonypi_acpi_remove(struct acpi_device *device, int type)
>>  	return 0;
>>  }
>>  
>> +static const struct acpi_device_id sonypi_acpi_driver_ids[] = {
>> +        {ACPI_PROCESSOR_HID, 0},
>>     
> This is wrong. You need to take the HID the driver should match for, in
> this case: {"SNY6001", 0 },
>   
Oh bugger, a cut 'n' paste error...
Thanks for reviewing it.


  reply	other threads:[~2007-08-05 20:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-05 19:05 Richard Knutsson
2007-08-05 19:50 ` Thomas Renninger
2007-08-05 20:03   ` Richard Knutsson [this message]
2007-08-07 19:07     ` Len Brown
2007-08-08  7:20       ` Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B62CFE.2010404@student.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=bcollins@ubuntu.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stelian@popies.net \
    --cc=trenn@suse.de \
    --subject='Re: [PATCH] sonypi: Fix initialization warning' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).