LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@xensource.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: CONFIG_XEN dependencies
Date: Tue, 23 Oct 2007 11:09:26 -0700	[thread overview]
Message-ID: <471E38D6.5050202@xensource.com> (raw)
In-Reply-To: <471DE2F8.76E4.0078.0@novell.com>

Jan Beulich wrote:
> Jeremy,
>
> CONFIG_XEN (in 2.6.23) depends on X86_CMPXCHG and X86_TSC. This
> precludes enabling the option in kernels using M386, M486, or M586, despite
> the fact that the detection code doesn't need these features and if Xen is
> present the features are implicitly there. At least the X86_TSC dependency
> can thus be dropped in my opinion, which would then only exclude M386
> kernels. (Dropping X86_CMPXCHG may yield build problems, but could
> perhaps also be eliminated by forcibly #define-ing it in the relevant source
> files.)

Yeah, that's a bit tacky though.  We added it because reviewers
(probably Adrian Bunk, or maybe akpm) noticed the Xen code
unconditionally using cmpxchg, and I added tsc because, well, we use it.

But you're right; we can't get to any of the Xen code without booting
under Xen, which necessarily means all those features are available,
regardless of how the kernel is configured.

What config combinations do you want to support?

    J

  reply	other threads:[~2007-10-23 18:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 10:03 Jan Beulich
2007-10-23 18:09 ` Jeremy Fitzhardinge [this message]
2007-10-24  8:31   ` Jan Beulich
2007-10-24 19:00     ` Jeremy Fitzhardinge
2007-10-24 19:53       ` Matt Mackall
2007-10-24 19:56         ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471E38D6.5050202@xensource.com \
    --to=jeremy@xensource.com \
    --cc=jbeulich@novell.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: CONFIG_XEN dependencies' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).