LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: LKML <linux-kernel@vger.kernel.org>, akpm@linux-foundation.org
Subject: Re: [PATCH 4/12] riscom8: fix SMP brokenness
Date: Wed, 24 Oct 2007 08:47:23 +0200	[thread overview]
Message-ID: <471EEA7B.8070008@gmail.com> (raw)
In-Reply-To: <20071023223638.DD9FE1F81A8@havoc.gtf.org>

On 10/24/2007 12:36 AM, Jeff Garzik wrote:
> After analyzing the elements that save_flags/cli/sti/restore_flags were
> protecting, convert their usages to a global spinlock (the easiest and
> most obvious next-step).  There were some usages of flags being
> intentionally cached, because the code already knew the state of
> interrupts.  These have been taken into account.
> 
> This allows us to remove CONFIG_BROKEN_ON_SMP.  Completely untested.
> 
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> ---
> 
[...]
> diff --git a/drivers/char/riscom8.c b/drivers/char/riscom8.c
> index b37e626..45d109c 100644
> --- a/drivers/char/riscom8.c
> +++ b/drivers/char/riscom8.c
[...]
> @@ -82,6 +83,8 @@
>  static struct riscom_board * IRQ_to_board[16];
>  static struct tty_driver *riscom_driver;
>  
> +static spinlock_t riscom_lock = SPIN_LOCK_UNLOCKED;

This is deprecated (see linux/spinlock_types.h for details), use DEFINE_SPINLOCK
instead, otherwise seems OK.

Revieweved-by: Jiri Slaby <jirislaby@gmail.com>

thanks,
-- 
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University

  reply	other threads:[~2007-10-24  6:47 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 22:36 [PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c Jeff Garzik
2007-10-23 22:36 ` [PATCH 2/12] X86: fix nvidia HPET warning Jeff Garzik
2007-10-24  4:05   ` Jeremy Fitzhardinge
2007-10-24  6:05     ` Jeff Garzik
2007-10-24 12:03   ` Ingo Molnar
2007-10-23 22:36 ` [PATCH 3/12] ACPI sbs: fix retval warning Jeff Garzik
2007-10-30 10:31   ` Jeff Garzik
2007-10-23 22:36 ` [PATCH 4/12] riscom8: fix SMP brokenness Jeff Garzik
2007-10-24  6:47   ` Jiri Slaby [this message]
2007-10-24  6:52     ` Jeff Garzik
2007-10-24  7:44       ` Jiri Slaby
2007-10-24  7:10     ` Andrew Morton
2007-10-24  7:44       ` Jiri Slaby
2007-10-24  8:00         ` Andrew Morton
2008-02-07  0:29   ` [bug] " Ingo Molnar
2008-02-20 20:37     ` Jeff Garzik
2008-02-20 22:00       ` Alan Cox
2007-10-23 22:36 ` [PATCH 5/12] ISDN/sc: fix longstanding warning Jeff Garzik
2007-10-24  7:24   ` Karsten Keil
2007-10-23 22:36 ` [PATCH 6/12] KVM: work around SMP requirement Jeff Garzik
2007-10-23 22:44   ` Adrian Bunk
2007-10-23 22:46     ` Jeff Garzik
2007-10-24  8:36       ` Avi Kivity
2007-10-24 12:32         ` [patch] kvm: fix !SMP build error Ingo Molnar
2007-10-24 12:36           ` Ingo Molnar
2007-10-24 18:11             ` Ingo Molnar
2007-11-01  3:34               ` Randy Dunlap
2007-11-01  8:31                 ` Ingo Molnar
2007-11-01 13:10                   ` Avi Kivity
2007-11-01 14:59                     ` Ingo Molnar
2007-11-01 21:16                       ` Avi Kivity
2007-10-23 22:36 ` [PATCH 7/12] eexpress: fix !SMP unused-var warning Jeff Garzik
2007-10-23 22:36 ` [PATCH 8/12] ni5010: kill unused variable Jeff Garzik
2007-10-23 22:36 ` [PATCH 9/12] cgroup: " Jeff Garzik
2007-10-24  0:19   ` Paul Menage
2007-10-23 22:36 ` [PATCH 10/12] mac80211: fix warning created by BIT() Jeff Garzik
2007-10-23 23:15   ` Randy Dunlap
2007-10-23 22:36 ` [PATCH 11/12] NET: fix subqueue bugs Jeff Garzik
2007-10-23 22:38   ` David Miller
2007-10-23 22:40     ` Jeff Garzik
2007-10-23 22:36 ` [PATCH 12/12] sound/isa: fix printk format Jeff Garzik
2007-10-24  4:03 ` [PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c Jeremy Fitzhardinge
2007-10-24 12:01 ` Ingo Molnar
2007-10-24 16:27 ` [2.6 patch] x86/kernel/acpi/processor.c: fix SMP=n warning Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471EEA7B.8070008@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 4/12] riscom8: fix SMP brokenness' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).