LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, tigran@aivazian.fsnet.co.uk,
	apw@shadowen.org
Subject: Re: [PATCH] 2.6.24-rc2-mm1 - Build Fail - fs/bfs/inode.c
Date: Wed, 14 Nov 2007 22:00:17 +0300	[thread overview]
Message-ID: <473B45C1.8070607@gmail.com> (raw)
In-Reply-To: <20071113212547.495f24dd.akpm@linux-foundation.org>

Andrew Morton пишет:
> On Wed, 14 Nov 2007 10:30:54 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> 
>> Hi Andrew,
>>
>> The kernel build fails, with following error
>>
>> fs/bfs/inode.c: In function ‘bfs_iget’:
>> fs/bfs/inode.c:37: error: ‘ino’ redeclared as different kind of symbol
>> fs/bfs/inode.c:35: error: previous definition of ‘ino’ was here
>> fs/bfs/inode.c:37: error: ‘inode’ undeclared (first use in this function)
>> fs/bfs/inode.c:37: error: (Each undeclared identifier is reported onlyonce
>> fs/bfs/inode.c:37: error: for each function it appears in.)
>> make[2]: *** [fs/bfs/inode.o] Error 1
>> make[1]: *** [fs/bfs] Error 2
>> make: *** [fs] Error 2
>>
>> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
>> --
>> --- linux-2.6.24-rc2/fs/bfs/inode.c	2007-11-14 09:53:41.000000000 +0530
>> +++ linux-2.6.24-rc2/fs/bfs/~inode.c	2007-11-14 10:21:06.000000000 +0530
>> @@ -34,7 +34,6 @@ void dump_imap(const char *prefix, struc
>>  
>>  struct inode *bfs_iget(struct super_block *sb, unsigned long ino)
>>  {
>> -	unsigned long ino = inode->i_ino;
>>  	struct bfs_inode *di;
>>  	struct inode *inode;
>>  	struct buffer_head *bh;
>>
> 
> bah.  That's what happens when I apply patches and fix rejects after doing
> all my compile-coverage testing.
> 
> Thanks.  I put your two fixes into the hot-fixes/ directory.

Andrew, I tested the BFS driver using the 2.6.24-rc2-mm1 kernel and I can confirm that the bugs I reported earlier are gone now.

Frankly, I was not expecting that my fixes would be applied on top of the "stop using iget() and read_inode()" patches, that is why I prepared my patch against the Linus tree. Thank you for your work in merging the modifications.

Dmitri

> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


      reply	other threads:[~2007-11-14 19:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-14  5:00 Kamalesh Babulal
2007-11-14  5:25 ` Andrew Morton
2007-11-14 19:00   ` Dmitri Vorobiev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473B45C1.8070607@gmail.com \
    --to=dmitri.vorobiev@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tigran@aivazian.fsnet.co.uk \
    --subject='Re: [PATCH] 2.6.24-rc2-mm1 - Build Fail - fs/bfs/inode.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).