LKML Archive on
help / color / mirror / Atom feed
From: Robert Hancock <>
To: Tejun Heo <>
Cc: linux-kernel <>,
	ide <>, Jeff Garzik <>
Subject: Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)
Date: Mon, 19 Nov 2007 23:25:48 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Tejun Heo wrote:
> Robert Hancock wrote:
>> Tejun Heo wrote:
>>> Robert Hancock wrote:
>>>> This fixes some problems with ATAPI devices on nForce4 controllers in
>>>> ADMA mode
>>>> on systems with memory located above 4GB. We need to delay setting
>>>> the 64-bit
>>>> DMA mask until the PRD table and padding buffer are allocated so that
>>>> they don't
>>>> get allocated above 4GB and break legacy mode (which is needed for ATAPI
>>>> devices).
>>>> Signed-off-by: Robert Hancock <>
>>> applied to #tj-upstream-fixes.
>> I have a report that these patches crashed but the previous patch worked:
>> So there may still be a problem here.
> Any progress?

It looks like the problem is that even though we set the DMA mask after 
we allocate the PRD and pad buffers, when the other port is set up, the 
DMA mask is already over 64-bit and so it allocates its buffers over 4GB 
and fails. I think we just need to explicitly set to 32-bit first, 
getting the reporter to try that one now.

Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from
Home Page:

  reply	other threads:[~2007-11-20  5:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-14  4:15 Robert Hancock
2007-11-14 12:05 ` Alan Cox
2007-11-15  1:38 ` Tejun Heo
2007-11-15  4:06   ` Robert Hancock
2007-11-15  4:11     ` Tejun Heo
2007-11-20  0:57     ` Tejun Heo
2007-11-20  5:25       ` Robert Hancock [this message]
2007-11-20  5:49         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).