LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: David Brownell <david-b@pacbell.net>, Greg KH <gregkh@suse.de>,
	Dave Young <hidave.darkstar@gmail.com>,
	stern@rowland.harvard.edu, peterz@infradead.org,
	davem@davemloft.net, krh@redhat.com,
	dbrownell@users.sourceforge.net,
	James.Bottomley@hansenpartnership.com, a.zummo@towertech.it,
	cbou@mail.ru, dwmw2@infradead.org,
	linux1394-devel@lists.sourceforge.net,
	spi-devel-general@lists.sourceforge.net,
	linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class
Date: Mon, 07 Jan 2008 17:36:32 +0100	[thread overview]
Message-ID: <47825510.7050306@s5r6.in-berlin.de> (raw)
In-Reply-To: <20080107140014.GA2961@ff.dom.local>

Jarek Poplawski wrote:
>> David Brownell wrote:
>> > On Monday 07 January 2008, Greg KH wrote:
>> >> Most of the non-driver core code should be converted to not use the
>> >> lock in the class at all.  They should use a local lock instead.
>> > 
>> > Or better yet, that yet-to-be-written class_for_each_instance()
>> > iterator ... :)
...
> I hope I'm wrong, but IMHO it should be safer not to mix such changes,
> so do the mutexes first or delay them until the end. Otherwise some
> false blaming seems almost inevitable.

I agree.  Sem2mutex conversion should not be mixed with API conversion,
even if one or both seem trivial.
-- 
Stefan Richter
-=====-==--- ---= --===
http://arcgraph.de/sr/

  reply	other threads:[~2008-01-07 16:37 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03  5:50 Dave Young
2008-01-03  7:06 ` Jarek Poplawski
2008-01-03  7:24   ` Jarek Poplawski
2008-01-03  7:21     ` Dave Young
2008-01-03  7:41       ` Jarek Poplawski
2008-01-06 18:41 ` Stefan Richter
2008-01-07  2:09   ` Dave Young
2008-01-07  8:45     ` Greg KH
2008-01-07  9:01       ` David Brownell
2008-01-07 13:23         ` Stefan Richter
2008-01-07 14:00           ` Jarek Poplawski
2008-01-07 16:36             ` Stefan Richter [this message]
2008-01-07 15:44           ` Greg KH
2008-01-07 17:13             ` Stefan Richter
2008-01-07 17:20               ` Greg KH
2008-01-08  7:05                 ` Dave Young
2008-01-08 22:48                   ` Greg KH
2008-01-09  1:32                     ` Dave Young
2008-01-09  6:13                       ` Dave Young
2008-01-09  6:37                         ` Dave Young
2008-01-09  6:39                           ` Dave Young
2008-01-10  9:48                             ` Dave Young
2008-01-10 12:34                               ` Stefan Richter
2008-01-11  2:18                                 ` Dave Young
2008-01-10 13:23                               ` Cornelia Huck
2008-01-11  2:33                                 ` Dave Young
2008-01-11  8:23                                   ` Cornelia Huck
2008-01-11  8:53                                     ` Dave Young
2008-01-10 15:41                               ` Alan Stern
2008-01-11  2:37                                 ` Dave Young
2008-01-10 18:39                               ` Greg KH
2008-01-11  2:40                                 ` Dave Young
2008-01-07 17:25               ` Alan Stern
2008-01-07 10:00       ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47825510.7050306@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=a.zummo@towertech.it \
    --cc=cbou@mail.ru \
    --cc=davem@davemloft.net \
    --cc=david-b@pacbell.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@suse.de \
    --cc=hidave.darkstar@gmail.com \
    --cc=jarkao2@gmail.com \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=peterz@infradead.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [PATCH 0/7] convert semaphore to mutex in struct class' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).