LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rene Herman <rene.herman@keyaccess.nl>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	alsa-devel@alsa-project.org, Jaroslav Kysela <perex@suse.cz>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [alsa-devel] PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236
Date: Thu, 10 Jan 2008 02:53:06 +0100	[thread overview]
Message-ID: <47857A82.4050005@keyaccess.nl> (raw)
In-Reply-To: <200801092343.48726.linux@rainbow-software.org>

On 09-01-08 23:43, Ondrej Zary wrote:

Jaroslav -- in your role as ISA-PnP maintainer and Bjorn, in yours as having 
been foollish enough to touch PnP recently:

> as hibernation (swsusp) started to work with my CPU, I found that my Turtle 
> Beach Malibu stops working after resume from hibernation. It's caused by fact 
> that the card is not enabled on the pnp layer during resume - and thus card 
> registers are inaccessible (reads return FFs, writes go nowhere).
> 
> During resume, pnp_bus_resume() in drivers/pnp/driver.c is called for each pnp 
> device. This function calls pnp_start_dev() only when the 
> PNP_DRIVER_RES_DO_NOT_CHANGE bit is NOT seting pnp_drv->flags. But the cs4236 
> driver in sound/isa/cs423x/cs4236.c explicitly sets the .flags to 
> PNP_DRIVER_RES_DISABLE - it's value is 3 and that includes 
> PNP_DRIVER_RES_DO_NOT_CHANGE bit.

Ehm. Isn't that a bit unexpected:

#define PNP_DRIVER_RES_DO_NOT_CHANGE    0x0001  /* do not change the state 
of the device */
#define PNP_DRIVER_RES_DISABLE          0x0003  /* ensure the device is 
disabled */

I'd say that disabling is changing, so isn't this just a braino where 
someone meant to write 2 instead of 3?

> The same .flags value is present in many of the ALSA ISA sound drivers.
> 
> Removing that .flags line caused this to appear inlog when loading snd_cs4236 
> module:
> CS4236+ WSS PnP manual resources are invalid, using auto config
> CS4236+ CTRL PnP manual resources are invalid, using auto config
> CS4236+ MPU401 PnP manual resources are invalid, using auto config
> 
> and the sound now works after resume!
> 
> So the question is: why is this line present?
> 
> Is this a bug? What's the correct fix?

Rene.


  reply	other threads:[~2008-01-10  1:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 22:43 PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236 Ondrej Zary
2008-01-10  1:53 ` Rene Herman [this message]
2008-01-10  7:58   ` [alsa-devel] " Jaroslav Kysela
2008-01-11  1:19     ` Rene Herman
2008-01-11  7:01       ` Pierre Ossman
2008-01-11 14:21         ` Rene Herman
2008-01-11 18:40           ` Ondrej Zary
2008-01-12  1:23             ` Rene Herman
2008-01-12 11:12               ` Pierre Ossman
2008-01-12 13:39                 ` Rene Herman
2008-01-12 15:21                   ` Pierre Ossman
2008-01-12 16:46                     ` Ondrej Zary
2008-01-12 17:00                     ` Rene Herman
2008-01-12 19:08                       ` Rafael J. Wysocki
2008-01-12 20:08                         ` -mm: pnp-do-not-stop-start-devices-in-suspend-resume-path.patch breaks resuming isapnp cards Rene Herman
2008-01-13  5:50                           ` Bjorn Helgaas
2008-01-13  6:13                             ` Rene Herman
2008-01-14 22:26                               ` Bjorn Helgaas
2008-01-14 23:46                                 ` Rene Herman
2008-01-15  7:51                                 ` Jaroslav Kysela
2008-01-16 17:46                                   ` Bjorn Helgaas
2008-01-16 18:03                                     ` Ondrej Zary
2008-01-16 18:16                                     ` Rene Herman
2008-01-12 19:01                   ` [alsa-devel] PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47857A82.4050005@keyaccess.nl \
    --to=rene.herman@keyaccess.nl \
    --cc=alsa-devel@alsa-project.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).