LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Reiser <jreiser@BitWagon.com>
To: Sam Ravnborg <sam@ravnborg.org>, Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: STT_FUNC for assembler checksum and semaphore ops" in git-x86
Date: Thu, 10 Jan 2008 08:37:44 -0800	[thread overview]
Message-ID: <478649D8.9080209@BitWagon.com> (raw)
In-Reply-To: <20080110074201.GA12585@uranus.ravnborg.org>

>>+       .type csum_partial, @function
>> ENTRY(csum_partial)
>>+       .type csum_partial, @function
>> ENTRY(csum_partial)
>>        CFI_STARTPROC
>>        pushl %esi
>>@@ -141,11 +142,13 @@ ENTRY(csum_partial)
>>        ret
>>        CFI_ENDPROC
>> ENDPROC(csum_partial)
>>+       .size csum_partial, . - csum_partial

>>AK [Andi Kleen]:
>>Better option would be to just add to ENTRY/ENDPROC ...

> John got more or less same comment from me [Sam Ravnborg] - but
> I did not hear further.
> As it stands out now it not nice.

It does look ugly.  But .size and .type are oriented towards static
description, while the dwarf2 CurrentFrameInfo (CFI) annotations
are oriented towards dynamic traceback and unwinding.  Forcing the
coupling between static and dynamic annotation might lead to trouble
when the fast path to 'ret' is in the middle, and code for the slow
path appears after the 'ret'; or when a recursive tail 'falls
through" into the entry point.

A quick test shows that multiple .size pseudo-ops for the same symbol
are accepted (the last one wins) so default coupling can be overridden.

I'll test revised macros and report shortly.

-- 
John Reiser, jreiser@BitWagon.com

  reply	other threads:[~2008-01-10 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 21:57 Andi Kleen
2008-01-10  7:42 ` Sam Ravnborg
2008-01-10 16:37   ` John Reiser [this message]
2008-01-10 18:02     ` Andi Kleen
2008-01-11  0:59       ` John Reiser
2008-01-11  2:57         ` Andi Kleen
2008-01-11  4:18           ` John Reiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478649D8.9080209@BitWagon.com \
    --to=jreiser@bitwagon.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    --subject='Re: STT_FUNC for assembler checksum and semaphore ops" in git-x86' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).