Re: [PATCH] checkpatch.pl: allow piping

[Jiri Slaby <jirislaby@gmail.com>]

On 01/11/2008 12:16 PM, Stefan Richter wrote:
> Daniel Walker wrote:
>> On Fri, 2008-01-11 at 10:34 +0100, Jiri Slaby wrote:
>>>>> On Fre, 2008-01-11 at 10:21 +0100, Jiri Slaby wrote:
>>>>>> git show 9914cad54c79d0b89b1f066c0894f00e1344131c
>>>>> | ./scripts/checkpatch.pl -
> 
>>> If somebody is hacking kernel, I think he should know the - trick used in many 
>>> programs, but do not consider this as a nack.
>> I'm hacking the kernel, and I didn't know the - trick .. So you have
>> your testing case all in one with the patch submitter ..
> 
> How about
> 
>  if ($#ARGV < 0) {
>  	print "usage: $P [options] patchfile\n";
>  	print "version: $V\n";
>  	print "options: -q           => quiet\n";
>  	print "         --no-tree    => run without a kernel tree\n";
>  	print "         --terse      => one line per report\n";
>  	print "         --emacs      => emacs compile window format\n";
>  	print "         --file       => check a source file\n";
>  	print "         --strict     => enable more subjective tests\n";
>  	print "         --root       => path to the kernel tree root\n";
> +	print "When patchfile is -, read standard input.\n";
>  	exit(1);
>  }
> 

My ACK.

regards,
-- 
Jiri Slaby
Faculty of Informatics, Masaryk University
Suse Labs