LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>,
	LKML <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>,
	Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl
Date: Mon, 14 Jan 2008 16:14:18 +0100	[thread overview]
Message-ID: <478B7C4A.5090903@gmail.com> (raw)
In-Reply-To: <aa79d98a0801132238o72266a91p78ae3a0c1476607c@mail.gmail.com>

On 01/14/2008 07:38 AM, Cyrill Gorcunov wrote:
> This patch converts ioctl call to unlocked_ioctl form. It's possible
> due to rtl_lock spinlock protection.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> The patch is *not* tested but the patch does not bring _much_ changes
> so it wouldn't break the compilation procedure.
> 
> If there is problem with attachment - i could send it as inline
> form today evening.

Yes, please, especially if it is app/octet-stream (base64 encoded plaintext). 
Also Cc akpm or somebody who will pick your patch up.

> Andi, Jiri, Alexey the only thing I do complain about -
> is time set/read from several user threads that uses same
> (duplicated) file descriptor. Could there be useless thread
> spins instead of sleep (in case if this unlocked_ioctl were
> protected by mutex)?

Sorry, what?

  reply	other threads:[~2008-01-14 15:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-13 20:32 [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl Cyrill Gorcunov
2008-01-13 21:07 ` Alexey Dobriyan
2008-01-13 21:25   ` Cyrill Gorcunov
2008-01-13 21:22 ` Jiri Slaby
2008-01-13 21:29   ` Jiri Slaby
2008-01-13 21:32     ` Cyrill Gorcunov
2008-01-14  6:38       ` Cyrill Gorcunov
2008-01-14 15:14         ` Jiri Slaby [this message]
2008-01-14 15:38           ` Cyrill Gorcunov
2008-01-14 15:59             ` Jiri Slaby
2008-01-14 16:07               ` Cyrill Gorcunov
2008-01-14 16:27                 ` Jiri Slaby
2008-01-14 16:28                   ` Cyrill Gorcunov
2008-01-13 23:08 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478B7C4A.5090903@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=ak@suse.de \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p_gortmaker@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).