LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drivers edac i3000 document type promotion
@ 2008-01-16  0:30 dougthompson
  0 siblings, 0 replies; only message in thread
From: dougthompson @ 2008-01-16  0:30 UTC (permalink / raw)
  To: linux-kernel, akpm

From: Jason Uhlenkott <juhlenko@akamai.com>

Applied to 2.6.24-rc6-mm1

By popular request, add a comment documenting the implicit type
promotion here.

Signed-off-by: Jason Uhlenkott <juhlenko@akamai.com>
Signed-off-by: Doug Thompson <dougthompson@xmission.com?
---
 i3000_edac.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux/drivers/edac/i3000_edac.c
===================================================================
--- linux.orig/drivers/edac/i3000_edac.c	2008-01-14 15:16:11.137167678 -0800
+++ linux/drivers/edac/i3000_edac.c	2008-01-14 15:16:13.387855416 -0800
@@ -44,6 +44,13 @@
 				 */
 #define I3000_DEAP_GRAIN 		(1 << 7)
 
+/*
+ * Helper functions to decode the DEAP/EDEAP hardware registers.
+ *
+ * The type promotion here is deliberate; we're deriving an
+ * unsigned long pfn and offset from hardware regs which are u8/u32.
+ */
+
 static inline unsigned long deap_pfn(u8 edeap, u32 deap)
 {
 	deap >>= PAGE_SHIFT;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-01-16  0:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-16  0:30 [PATCH] drivers edac i3000 document type promotion dougthompson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).