LKML Archive on
help / color / mirror / Atom feed
From: Peter Staubach <>
To: Chuck Lever <>
Cc: Linux Kernel Mailing List <>,,
	Andrew Morton <>,
	Trond Myklebust <>,
	linux-fsdevel <>
Subject: Re: [PATCH 0/3] enhanced ESTALE error handling
Date: Fri, 18 Jan 2008 11:55:15 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Chuck Lever wrote:
> Hi Peter-
> On Jan 18, 2008, at 10:35 AM, Peter Staubach wrote:
>> Hi.
>> Here is a patch set which modifies the system to enhance the
>> ESTALE error handling for system calls which take pathnames
>> as arguments.
> The VFS already handles ESTALE.
> If a pathname resolution encounters an ESTALE at any point, the 
> resolution is restarted exactly once, and an additional flag is passed 
> to the file system during each lookup that forces each component in 
> the path to be revalidated on the server.  This has no possibility of 
> causing an infinite loop.
> Is there some part of this logic that is no longer working? 

The VFS does not fully handle ESTALE.  An ESTALE error can occur
during the second pathname resolution attempt.  There are lots of
reasons, some of which are the 1 second resolution from some file
systems on the server and the window in between the revalidation
and the actual use of the file handle associated with each
dentry/inode pair.

Also, there was no support for ESTALE errors which occur during
subsequent operations to the pathname resolution process.  For
example, during a mkdir(2) operation, the ESTALE can occur from
the over the wire MKDIR operation after the LOOKUP operations
have all succeeded.



  reply	other threads:[~2008-01-18 16:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 15:35 Peter Staubach
2008-01-18 15:46 ` J. Bruce Fields
2008-01-18 16:41 ` Chuck Lever
2008-01-18 16:55   ` Peter Staubach [this message]
2008-01-18 17:17     ` Chuck Lever
2008-01-18 17:30       ` Peter Staubach
2008-01-18 17:52         ` Chuck Lever
2008-01-18 18:12           ` Peter Staubach
2008-01-18 18:37             ` J. Bruce Fields
2008-01-18 19:12               ` Peter Staubach
2008-01-18 18:17         ` Chuck Lever
2008-02-01 20:57 ` [PATCH 0/3] enhanced ESTALE error handling (v2) Peter Staubach
2008-03-10 20:23   ` [PATCH 0/3] enhanced ESTALE error handling (v3) Peter Staubach
2008-03-10 22:42     ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 0/3] enhanced ESTALE error handling' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).