LKML Archive on
help / color / mirror / Atom feed
From: Joel Schopp <>
To: Dmitri Vorobiev <>
Cc: Tigran Aivazian <>,,,,,
	Linux-kernel <>
Subject: Re: [PATCH v2 8/9] bfs: remove multiple assignments
Date: Mon, 28 Jan 2008 01:02:03 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

>>> -    inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
>>> +    inode->i_mtime = CURRENT_TIME_SEC;
>>> +    inode->i_atime = CURRENT_TIME_SEC;
>>> +    inode->i_ctime = CURRENT_TIME_SEC;
>> multiple assignments like "x = y = z = value;" can potentially
>> (depending on the compiler and arch) be faster than "x = value; y =
>> value; z=value;"
>> I am surprized that this script complains about them as it is a
>> perfectly valid thing to do in C.
> I think it seems wise to ask the maintainers of to
> comment on that. I'm Cc:ing them now.

There are plenty of things that are valid to do in C that don't make for 
maintainable code.  These scripts are designed to make your code easier for 
real people to review and maintain.

As for if this can be faster we don't deal in the realm of "can".  Please 
show a concrete example of gcc making Linux kernel code faster with 
multiple assignments per line.  If you can do that I'm willing to change my 
mind and I'll lead the charge for mutliple assignments per line.

  reply	other threads:[~2008-01-28  7:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
     [not found] ` <>
     [not found]   ` <Pine.LNX.4.61.0801261833270.1966@ginsburg.homenet>
2008-01-26 23:48     ` Dmitri Vorobiev
2008-01-28  7:02       ` Joel Schopp [this message]
2008-01-30 13:06         ` Al Viro
2008-01-30 13:36           ` Dmitri Vorobiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 8/9] bfs: remove multiple assignments' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).