LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Markus Rechberger" <markus.rechberger@amd.com>
To: Matt_Domsch@dell.com,
	"Jos?? Luis Tall??n" <jltallon@adv-solutions.net>,
	Douglas_Warzecha@dell.com, Abhay_Salunke@dell.com,
	linux-kernel@vger.kernel.org, matt_domsch@dell.com,
	"Michael E Brown" <Michael_E_Brown@dell.com>,
	"Greg KH" <gregkh@suse.de>, "Jean Delvare" <khali@linux-fr.org>
Subject: Re: FW: 2.6.24 breaks BIOS updates on all Dell machines
Date: Tue, 29 Jan 2008 15:59:44 +0100	[thread overview]
Message-ID: <479F3F60.8050108@amd.com> (raw)
In-Reply-To: <E9909A75A543064DB66E55B8E3BE41EC5FD218@ausx3mps307.aus.amer.dell.com>

Matt_Domsch@Dell.com wrote:
> Markus, I see you were accidentally left off the cc: list on this bug.
> The change was yours, so I suspect you'll have an opinion to share with
> LKML.
>
> Thanks,
> Matt
>
> --
> Matt Domsch
> Linux Technology Strategist, Dell Office of the CTO
> linux.dell.com & www.dell.com/linux
>
> -----Original Message-----
> From: Greg KH [mailto:gregkh@suse.de] 
> Sent: Tuesday, January 29, 2008 12:44 AM
> To: Brown, Michael E
> Cc: Jos?? Luis Tall??n; Warzecha, Douglas; Salunke, Abhay;
> linux-kernel@vger.kernel.org; Domsch, Matt; marcel@holtmann.org
> Subject: Re: 2.6.24 breaks BIOS updates on all Dell machines
>
> On Tue, Jan 29, 2008 at 12:32:44AM -0600, Michael E Brown wrote:
>   
>> BIOS updates are broken on all Dell systems due to Commit
>> 109f0e93b6b728f03c1eb4af02bc25d71b646c59, which is now in 2.6.24.
>>
>>   static inline void fw_setup_device_id(struct device *f_dev, struct
>> device *dev)
>>   {
>> -       /* XXX warning we should watch out for name collisions */
>> -       strlcpy(f_dev->bus_id, dev->bus_id, BUS_ID_SIZE);
>> +       snprintf(f_dev->bus_id, BUS_ID_SIZE, "firmware-%s",
>> dev->bus_id);
>>  }
>>
>> Two programs are broken by this change: 
>>     1) dellBiosUpdate, which is part of libsmbios
>>     2) All of the Dell Update Packages (DUPs) that are part of Dell
>> OpenManage: each BIOS release for each of 3-4 dozen platforms.
>>
>> These programs are broken due to the pathname change from
>> /sys/class/firmware/dell_rbu/   to
>> /sys/class/firmware/firmware-dell_rbu/loading. 
>>
>> Realistically, I can fix libsmbios in a couple of weeks, but there is
>>     
> no
>   
>> way that we can go back and fix a couple hundred DUP packages for this
>> change. If this stays, we are looking at over 6 months before we have
>>     
> an
>   
>> officially-available Dell OpenManage that can deal with it, and that
>> would be for new BIOS releases only, I suspect.
>>
>> Some of the relevant threads from when this was submitted and
>>     
> accepted:
>   
>> http://lkml.org/lkml/2005/5/23/73
>> http://lkml.org/lkml/2005/5/23/62
>>
>> Due to the extremely large and disruptive nature of this bug, it would
>> be nice to get a 2.6.24.1 with this patch reverted.
>>
>> I have copied the relevant developers at Dell who maintain this
>>     
> driver.
>   
>> Please preserve the cc: list when replying.
>>     
>
> Fair enough, I have no problem reverting this.
>
> Anyone want to keep it in?
>
>   
Hi Greg,

reverting this breaks support for several media (DVB/V4L) devices. I 
would have to look up some bugreports the same name collision happened 
with several different drivers.
There was a comment in the fw code to watch out for name collisions 
earlier already, so it needs a fix somewhere.

Here's some history:
http://mcentral.de/wiki/index.php5/Bugtracker#i2c_dev_problem

Markus



       reply	other threads:[~2008-01-29 14:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E9909A75A543064DB66E55B8E3BE41EC5FD218@ausx3mps307.aus.amer.dell.com>
2008-01-29 14:59 ` Markus Rechberger [this message]
2008-01-29 18:41   ` Greg KH
2008-01-29 22:15     ` Jean Delvare
2008-02-05  6:45       ` Greg KH
2008-02-05 20:16         ` Jean Delvare
2008-02-05 23:44           ` Greg KH
2008-02-06 13:20             ` Jean Delvare
2008-01-29 19:04   ` FW: " Sytse Wielinga
     [not found]     ` <20080129190924.GB8786@humbolt.us.dell.com>
2008-02-03 14:02       ` Jean Delvare
     [not found]         ` <20080204155834.GA32437@humbolt.us.dell.com>
2008-02-05 16:25           ` Jean Delvare
     [not found] <20080129063244.GA19076@humbolt.us.dell.com>
2008-01-29  6:44 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479F3F60.8050108@amd.com \
    --to=markus.rechberger@amd.com \
    --cc=Abhay_Salunke@dell.com \
    --cc=Douglas_Warzecha@dell.com \
    --cc=Matt_Domsch@dell.com \
    --cc=Michael_E_Brown@dell.com \
    --cc=gregkh@suse.de \
    --cc=jltallon@adv-solutions.net \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: FW: 2.6.24 breaks BIOS updates on all Dell machines' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).