LKML Archive on lore.kernel.org help / color / mirror / Atom feed
* [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver @ 2008-01-30 3:41 Kamalesh Babulal 2008-01-30 4:43 ` Gabriel C 2008-01-30 5:34 ` Sam Ravnborg 0 siblings, 2 replies; 5+ messages in thread From: Kamalesh Babulal @ 2008-01-30 3:41 UTC (permalink / raw) To: LKML, netdev, romieu, Andy Whitcroft Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 # gcc --version (machine1) gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) # gcc --version (machine2) gcc (GCC) 4.1.1 20060525 (Red Hat 4.1.1-1) -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver 2008-01-30 3:41 [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver Kamalesh Babulal @ 2008-01-30 4:43 ` Gabriel C 2008-01-30 8:01 ` Kamalesh Babulal 2008-01-30 5:34 ` Sam Ravnborg 1 sibling, 1 reply; 5+ messages in thread From: Gabriel C @ 2008-01-30 4:43 UTC (permalink / raw) To: Kamalesh Babulal; +Cc: LKML, netdev, romieu, Andy Whitcroft Kamalesh Babulal wrote: > Hi, > > The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[2]: *** [drivers/net/sis190.o] Error 1 > > # gcc --version (machine1) > gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) > > # gcc --version (machine2) > gcc (GCC) 4.1.1 20060525 (Red Hat 4.1.1-1) > Heh :) vger.kernel.org does not like emails directly from gmail , it seems =) ( sorry for sending this 3 time now ) The following patch should fix the build failure. diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b570402..e48e4ad 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -326,7 +326,7 @@ static const struct { { "SiS 191 PCI Gigabit Ethernet adapter" }, }; -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { +static const struct pci_device_id sis190_pci_tbl[] __devinitdata = { { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, { 0, }, Gabriel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver 2008-01-30 4:43 ` Gabriel C @ 2008-01-30 8:01 ` Kamalesh Babulal 0 siblings, 0 replies; 5+ messages in thread From: Kamalesh Babulal @ 2008-01-30 8:01 UTC (permalink / raw) To: Gabriel C; +Cc: LKML, netdev, romieu, Andy Whitcroft Gabriel C wrote: > Kamalesh Babulal wrote: >> Hi, >> >> The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure >> >> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict >> make[2]: *** [drivers/net/sis190.o] Error 1 >> >> # gcc --version (machine1) >> gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) >> >> # gcc --version (machine2) >> gcc (GCC) 4.1.1 20060525 (Red Hat 4.1.1-1) >> > > Heh :) vger.kernel.org does not like emails directly from gmail , it seems =) > > ( sorry for sending this 3 time now ) > > The following patch should fix the build failure. > > diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c > index b570402..e48e4ad 100644 > --- a/drivers/net/sis190.c > +++ b/drivers/net/sis190.c > @@ -326,7 +326,7 @@ static const struct { > { "SiS 191 PCI Gigabit Ethernet adapter" }, > }; > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > +static const struct pci_device_id sis190_pci_tbl[] __devinitdata = { > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, > { 0, }, > > > Gabriel Hi Gabriel, Thanks, the patch fixes the build failure. -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver 2008-01-30 3:41 [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver Kamalesh Babulal 2008-01-30 4:43 ` Gabriel C @ 2008-01-30 5:34 ` Sam Ravnborg 2008-01-30 8:03 ` Kamalesh Babulal 1 sibling, 1 reply; 5+ messages in thread From: Sam Ravnborg @ 2008-01-30 5:34 UTC (permalink / raw) To: Kamalesh Babulal; +Cc: LKML, netdev, romieu, Andy Whitcroft On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: > Hi, > > The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[2]: *** [drivers/net/sis190.o] Error 1 > > # gcc --version (machine1) > gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) > > # gcc --version (machine2) > gcc (GCC) 4.1.1 20060525 (Red Hat 4.1.1-1) Hi Kamalesh I know another patch is circulating, but please try the following. diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b570402..0a5e024 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -1556,7 +1556,7 @@ static int __devinit sis190_get_mac_addr_from_eeprom(struct pci_dev *pdev, static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev, struct net_device *dev) { - static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; + static const u16 __devinitconst ids[] = { 0x0965, 0x0966, 0x0968 }; struct sis190_private *tp = netdev_priv(dev); struct pci_dev *isa_bridge; u8 reg, tmp8; It is the better fix if you can confirm it working. The section conflict issued by gcc happens because we try to mix const and non-const data in the same section. Sam ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver 2008-01-30 5:34 ` Sam Ravnborg @ 2008-01-30 8:03 ` Kamalesh Babulal 0 siblings, 0 replies; 5+ messages in thread From: Kamalesh Babulal @ 2008-01-30 8:03 UTC (permalink / raw) To: Sam Ravnborg; +Cc: LKML, netdev, romieu, Andy Whitcroft Sam Ravnborg wrote: > On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: >> Hi, >> >> The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure >> >> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict >> make[2]: *** [drivers/net/sis190.o] Error 1 >> >> # gcc --version (machine1) >> gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) >> >> # gcc --version (machine2) >> gcc (GCC) 4.1.1 20060525 (Red Hat 4.1.1-1) > > Hi Kamalesh > > I know another patch is circulating, but please try the following. Hi Sam, Thanks, the patch fixes the build failure. Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> > diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c > index b570402..0a5e024 100644 > --- a/drivers/net/sis190.c > +++ b/drivers/net/sis190.c > @@ -1556,7 +1556,7 @@ static int __devinit sis190_get_mac_addr_from_eeprom(struct pci_dev *pdev, > static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev, > struct net_device *dev) > { > - static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; > + static const u16 __devinitconst ids[] = { 0x0965, 0x0966, 0x0968 }; > struct sis190_private *tp = netdev_priv(dev); > struct pci_dev *isa_bridge; > u8 reg, tmp8; > > It is the better fix if you can confirm it working. > The section conflict issued by gcc happens because we try to > mix const and non-const data in the same section. > > Sam -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-01-30 8:09 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2008-01-30 3:41 [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver Kamalesh Babulal 2008-01-30 4:43 ` Gabriel C 2008-01-30 8:01 ` Kamalesh Babulal 2008-01-30 5:34 ` Sam Ravnborg 2008-01-30 8:03 ` Kamalesh Babulal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).