LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roel kluin <rjckluin@hotmail.com>
To: ibm-acpi@hmh.eng.br, len.brown@intel.com
Cc: linux-acpi@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net,
	lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'
Date: Mon, 04 Feb 2008 22:59:21 +0100	[thread overview]
Message-ID: <47A78AB9.5020901@hotmail.com> (raw)

in drivers/misc/thinkpad_acpi.c, lines 4137-4142 it reads:

                /* safety net should the EC not support AUTO
                 * or FULLSPEED mode bits and just ignore them */
                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                else if (level & TP_EC_FAN_FULLSPEED)
                        level |= 4;     /* safety min speed 4 */

note the nonsense duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'.
should this be changed to:

                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                else
                        level |= 4;     /* safety min speed 4 */

or maybe

                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 4;     /* safety min speed 4 */

?

             reply	other threads:[~2008-02-04 22:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 21:59 Roel kluin [this message]
2008-02-04 22:07 [drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED) Roel Kluin
2008-02-04 22:13 ` Roland Dreier
2008-02-04 23:24   ` [PATCH][drivers/misc/thinkpad_acpi.c] " Roel Kluin
2008-02-05  5:05     ` Henrique de Moraes Holschuh
2008-02-05  8:34       ` Roel Kluin
2008-02-06 23:07         ` Greg KH
2008-02-06 23:48           ` Roel Kluin
2008-02-07  1:18             ` Henrique de Moraes Holschuh
2008-02-07  6:17     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A78AB9.5020901@hotmail.com \
    --to=rjckluin@hotmail.com \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test '\''if (level & TP_EC_FAN_FULLSPEED)'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).