LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: Christoph Lameter <clameter@sgi.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: SLUB: Support for statistics to help analyze allocator behavior
Date: Tue, 05 Feb 2008 08:49:39 +0100	[thread overview]
Message-ID: <47A81513.4010301@cosmosbay.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0802050923220.14675@sbz-30.cs.Helsinki.FI>

Pekka J Enberg a écrit :
> Hi Christoph,
> 
> On Mon, 4 Feb 2008, Christoph Lameter wrote:
>> The statistics provided here allow the monitoring of allocator behavior
>> at the cost of some (minimal) loss of performance. Counters are placed in
>> SLUB's per cpu data structure that is already written to by other code.
> 
> Looks good but I am wondering if we want to make the statistics per-CPU so 
> that we can see the kmalloc/kfree ping-pong of, for example, hackbench 
> better?

AFAIK Christoph patch already have percpu statistics :)


+#define STAT_ATTR(si, text) 					\
+static ssize_t text##_show(struct kmem_cache *s, char *buf)	\
+{								\
+	unsigned long sum  = 0;					\
+	int cpu;						\
+								\
+	for_each_online_cpu(cpu)				\
+		sum += get_cpu_slab(s, cpu)->stat[si];		\
+	return sprintf(buf, "%lu\n", sum);			\
+}								\


  reply	other threads:[~2008-02-05  7:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05  6:20 Christoph Lameter
2008-02-05  7:24 ` Pekka J Enberg
2008-02-05  7:49   ` Eric Dumazet [this message]
2008-02-05  7:54     ` Pekka J Enberg
2008-02-05 18:08       ` Christoph Lameter
2008-02-05 18:55         ` Eric Dumazet
2008-02-05 19:07           ` Christoph Lameter
2008-02-05 18:05   ` Christoph Lameter
2008-02-05 20:20     ` Pekka Enberg
2008-02-05 21:58       ` Christoph Lameter
2008-02-05 22:19         ` Pekka J Enberg
2008-02-06  8:19 ` Andrew Morton
2008-02-06 19:01   ` Christoph Lameter
2008-02-06 21:00   ` SLUB: statistics improvements Christoph Lameter
2008-02-06 21:40     ` Eric Dumazet
2008-02-06 22:10       ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A81513.4010301@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    --subject='Re: SLUB: Support for statistics to help analyze allocator behavior' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).