LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.
@ 2008-02-05 12:15 Rami Rosen
  2008-02-05 17:38 ` James Chapman
  2008-02-05 18:22 ` Jeff Garzik
  0 siblings, 2 replies; 5+ messages in thread
From: Rami Rosen @ 2008-02-05 12:15 UTC (permalink / raw)
  To: netdev, jeff, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

Hi,

When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set,
we have the following warning in build:
  drivers/net/pppol2tp.c: In function 'pppol2tp_init':
  drivers/net/pppol2tp.c:2472: warning: label
'out_unregister_pppox_proto' defined but not used

This patches fixes this warning by adding appropriate #ifdef.

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 420 bytes --]

diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c
index 1b51bb6..5aa0a80 100644
--- a/drivers/net/pppol2tp.c
+++ b/drivers/net/pppol2tp.c
@@ -2468,9 +2468,10 @@ static int __init pppol2tp_init(void)
 
 out:
 	return err;
-
+#ifdef CONFIG_PROC_FS
 out_unregister_pppox_proto:
 	unregister_pppox_proto(PX_PROTO_OL2TP);
+#endif
 out_unregister_pppol2tp_proto:
 	proto_unregister(&pppol2tp_sk_proto);
 	goto out;

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.
  2008-02-05 12:15 [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set Rami Rosen
@ 2008-02-05 17:38 ` James Chapman
  2008-02-06  0:31   ` David Miller
  2008-02-05 18:22 ` Jeff Garzik
  1 sibling, 1 reply; 5+ messages in thread
From: James Chapman @ 2008-02-05 17:38 UTC (permalink / raw)
  To: Rami Rosen; +Cc: netdev, jeff, linux-kernel

Acked-by: James Chapman <jchapman@katalix.com>

Rami Rosen wrote:
> Hi,
> 
> When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set,
> we have the following warning in build:
>   drivers/net/pppol2tp.c: In function 'pppol2tp_init':
>   drivers/net/pppol2tp.c:2472: warning: label
> 'out_unregister_pppox_proto' defined but not used
> 
> This patches fixes this warning by adding appropriate #ifdef.
> 
> Regards,
> Rami Rosen
> 
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> 


-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.
  2008-02-05 12:15 [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set Rami Rosen
  2008-02-05 17:38 ` James Chapman
@ 2008-02-05 18:22 ` Jeff Garzik
  2008-02-06  0:32   ` David Miller
  1 sibling, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2008-02-05 18:22 UTC (permalink / raw)
  To: Rami Rosen; +Cc: netdev, linux-kernel, Paul Mackerras, David Miller

Rami Rosen wrote:
> Hi,
> 
> When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set,
> we have the following warning in build:
>   drivers/net/pppol2tp.c: In function 'pppol2tp_init':
>   drivers/net/pppol2tp.c:2472: warning: label
> 'out_unregister_pppox_proto' defined but not used
> 
> This patches fixes this warning by adding appropriate #ifdef.
> 
> Regards,
> Rami Rosen
> 
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>


David or Paul, wanna pick this up?


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.
  2008-02-05 17:38 ` James Chapman
@ 2008-02-06  0:31   ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2008-02-06  0:31 UTC (permalink / raw)
  To: jchapman; +Cc: ramirose, netdev, jeff, linux-kernel

From: James Chapman <jchapman@katalix.com>
Date: Tue, 05 Feb 2008 17:38:10 +0000

> Acked-by: James Chapman <jchapman@katalix.com>

Applied, thanks everyone.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.
  2008-02-05 18:22 ` Jeff Garzik
@ 2008-02-06  0:32   ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2008-02-06  0:32 UTC (permalink / raw)
  To: jeff; +Cc: ramirose, netdev, linux-kernel, paulus

From: Jeff Garzik <jeff@garzik.org>
Date: Tue, 05 Feb 2008 13:22:19 -0500

> David or Paul, wanna pick this up?

I took it, no worries.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-02-06  0:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-05 12:15 [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set Rami Rosen
2008-02-05 17:38 ` James Chapman
2008-02-06  0:31   ` David Miller
2008-02-05 18:22 ` Jeff Garzik
2008-02-06  0:32   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).