LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Greg KH <greg@kroah.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
	???????????? ?????????????????????? <penguinista@mail.net.mk>,
	Shaohua Li <shaohua.li@intel.com>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>
Subject: Re: PCIE ASPM support hangs my laptop pretty often
Date: Tue, 05 Feb 2008 12:58:56 -0800	[thread overview]
Message-ID: <47A8CE10.4010807@intel.com> (raw)
In-Reply-To: <20080205185100.GA4633@kroah.com>

Greg KH wrote:
> On Tue, Feb 05, 2008 at 10:46:23AM -0800, Arjan van de Ven wrote:
>> On Tue, 5 Feb 2008 18:40:04 +0100
>> ???????????? ??????????????????????  <penguinista@mail.net.mk> wrote:
>>
>>> I've patched my kernel with the PCIe ASPM and after setting
>>> echo powersave > /sys/module/pcie_aspm/parameters/policy
>>>
>>> I started to experience random hangs of my laptop.
>>> Hardware info:
>>> Thinkpad x60s 1704-5UG
>> the x60's chipset doesn't support ASPM properly afaik... bad idea.
> 
> Well, the code shouldn't then cause a crash of the machine :)

The user enabled it specifically (where it is disabled by default)

ASPM has been crashing e1000(e), which is why I've recently merged a patch to
disable L1 ASPM for the onboard 82573 nic on those platforms.

this new infrastructure should work in the default configuration - enabling ASPM
where this system leaves it disabled is expected to give problems unless you know
what you are doing.

Auke

  reply	other threads:[~2008-02-05 20:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 17:40 Дамјан Георгиевски
2008-02-05 18:46 ` Arjan van de Ven
2008-02-05 18:51   ` Greg KH
2008-02-05 20:58     ` Kok, Auke [this message]
2008-02-06  0:05       ` Дамјан Георгиевски
2008-02-06  0:22         ` Kok, Auke
2008-02-06 13:00           ` Pavel Machek
2008-02-06 17:25             ` Rafael J. Wysocki
2008-02-06 21:46               ` Kok, Auke
2008-02-06 21:58                 ` Greg KH
2008-02-19  5:55 ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A8CE10.4010807@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=arjan@infradead.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=penguinista@mail.net.mk \
    --cc=shaohua.li@intel.com \
    --subject='Re: PCIE ASPM support hangs my laptop pretty often' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).