LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Max Krasnyanskiy <maxk@qualcomm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Steven Rostedt <srostedt@redhat.com>, Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: RT scheduler config, suggestions and questions
Date: Tue, 05 Feb 2008 15:37:12 -0800	[thread overview]
Message-ID: <47A8F328.5070107@qualcomm.com> (raw)

Folks,

I just realized that in latest Linus' tree following sysctls are under SCHED_DEBUG:
	sched_rt_period
	sched_rt_ratio

I do not believe that is correct. I know that we do not want to expose scheduler knobs
in general but theses are not the heuristic kind of knobs. There is no way the scheduler 
can magically figure out what the correct setting should be here.

Also shouldn't those new RT features that recently went be configurable and _disabled_ 
by default ? For example "RT watchdog" and "RT throttling" actually seem very questionable. 
SCHED_FIFO is clearly defined as
"
  A SCHED_FIFO process runs until either it is blocked by an I/O request, it is preempted 
  by a higher priority process, or it calls sched_yield(2).
"

Both the watchdog and the throttling are clearly braking that rule. I think it's good to have 
those features but not enabled by default and certainly not with sysctls that disable them 
hidden under debugging.
How about this:
- We introduce Kconfig options for them ?
- Expose all rt sysctls outside of #ifdef DEBUG

I can kook up some patches if that sounds ok.

----

btw I can see "watchdog" being very useful to catch hard-RT tasks that exceed the deadline.
But's it gotta be per thread. Single setting per user is not enough. Unless a use has a single 
RT task.

Max

             reply	other threads:[~2008-02-05 23:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 23:37 Max Krasnyanskiy [this message]
2008-02-06  6:36 ` Peter Zijlstra
2008-02-06 11:29   ` Peter Zijlstra
2008-02-06 18:04     ` Max Krasnyanskiy
2008-02-06 21:50       ` Peter Zijlstra
2008-02-06 17:52   ` Max Krasnyanskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A8F328.5070107@qualcomm.com \
    --to=maxk@qualcomm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=srostedt@redhat.com \
    --subject='Re: RT scheduler config, suggestions and questions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).