LKML Archive on
help / color / mirror / Atom feed
From: Sergei Shtylyov <>
To: Jan Kiszka <>
Cc: Jason Wessel <>,, Ingo Molnar <>,
	Linux Kernel Mailing List <>
Subject: Re: [Kgdb-bugreport] [PATCH 4/5] KGDB-8250: refactor configuration
Date: Wed, 06 Feb 2008 16:16:48 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


Jan Kiszka wrote:

>>>Sorry, previous version was missing some __init[data] attributes which
>>>were dropped in an intermediate stage. Here comes an updated patch:


>>>This major refactoring of the quite complex kgdb8250 configuration does
>>>the following:

>>> - ensures that static configurations according to SERIAL_PORT_DFNS are
>>>   always loaded first
>>> - tries to pull more accurate configuration via serial8250_get_port_def
>>>   if simple-config is used
>>> - detects empty/invalid simple-configs
>>> - enforces KGDB_PORT_NUM <= SERIAL_8250_NR_UARTS at kconfig level
>>> - removes kgdb8250_add_port and its hook in serial_core (calling
>>>   serial8250_get_port_def in demand should provide us the same
>>>   information)

>>   You left powerpc-lite.patch broken with this change as it has
>>multiple calls to kgdb8250_add_port()...

> I see. But I wonder if there ever was a real need for these hooks (in
> 2.4 times?): If I look at bamboo_early_serial_map() e.g., I find it
> calling into early_serial_setup() which fills serial8250_ports[] - and
> that content is now retrieved via serial8250_get_port_def() when we
> parse the runtime or build-time provided parameters (port number &
> baudrate).

    Of course. But now the kgdb8250_add_port() calls need to be removed.

>>>Signed-off-by: Jan Kiszka <>

WBR, Sergei

  reply	other threads:[~2008-02-06 13:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-29 23:46 Jan Kiszka
2008-01-30  0:31 ` Jan Kiszka
2008-02-01 13:59   ` [Kgdb-bugreport] " Sergei Shtylyov
2008-02-01 21:10     ` Jan Kiszka
2008-02-06 13:16       ` Sergei Shtylyov [this message]
2008-02-06 17:52         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [Kgdb-bugreport] [PATCH 4/5] KGDB-8250: refactor configuration' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).