Re: [Kgdb-bugreport] [PATCH 4/5] KGDB-8250: refactor configuration

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

Sergei Shtylyov wrote:
>>>   You left powerpc-lite.patch broken with this change as it has
>>> multiple calls to kgdb8250_add_port()...
> 
>> I see. But I wonder if there ever was a real need for these hooks (in
>> 2.4 times?): If I look at bamboo_early_serial_map() e.g., I find it
>> calling into early_serial_setup() which fills serial8250_ports[] - and
>> that content is now retrieved via serial8250_get_port_def() when we
>> parse the runtime or build-time provided parameters (port number &
>> baudrate).
> 
>    Of course. But now the kgdb8250_add_port() calls need to be removed.

For sure. Most arch patches need to go through some refactoring anyway
when preparing them for upstream. Cleaning up no longer required hooks
should be no problem at this chance.

If you want to accelerate this process, please check out Jason's
linux-2.6-kgdb.git for 2.6.25 and start rebasing the powerpc patch. He
just recently said that support around kgdb for non-x86 would be highly
welcome. And if you stumble over ppc-related issues that cannot be
solved with latest kgdb design, please let us know. The sooner, the better.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]