LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] KGDB-8250: fix initial interrupt
@ 2008-02-07  7:38 Jan Kiszka
  0 siblings, 0 replies; only message in thread
From: Jan Kiszka @ 2008-02-07  7:38 UTC (permalink / raw)
  To: Jason Wessel; +Cc: Linux Kernel Mailing List, kgdb-bugreport

Latest rework of kgdb8250_interrupt caused a regression in that the new
code wrongly assumes a ctrl-c character is also sent on initial connect
from the host. Here is a fix.

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>

---
 drivers/serial/8250_kgdb.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: b/drivers/serial/8250_kgdb.c
===================================================================
--- a/drivers/serial/8250_kgdb.c
+++ b/drivers/serial/8250_kgdb.c
@@ -124,10 +124,10 @@ static irqreturn_t kgdb8250_interrupt(in

 	if ((iir & UART_IIR_ID) == UART_IIR_RDI) {
 		c = kgdb8250_ioread(UART_RX);
-		if (c == 0x03)
-			breakpoint();
-		else
+		if (c != 0x03)
 			buffered_char = c;
+		if (c == 0x03 || !kgdb_connected)
+			breakpoint();
 	}
 	return IRQ_HANDLED;
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-07  7:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-07  7:38 [PATCH] KGDB-8250: fix initial interrupt Jan Kiszka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).