LKML Archive on
help / color / mirror / Atom feed
From: Jan Kiszka <>
To: Jason Wessel <>
Cc: Ingo Molnar <>,
	Linux Kernel Mailing List <>,,
	Thomas Gleixner <>,
	"H. Peter Anvin" <>
Subject: Re: [PATCH 1/3] KGDB: Major refactoring
Date: Thu, 07 Feb 2008 08:47:55 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]

Jason Wessel wrote:
> Ingo Molnar wrote:
>> * Jan Kiszka <> wrote:
>>> As most changes are tightly coupled, this refactoring patch for
>>> KGDB_8250 as well as the core and the new KGDBOC driver comes as a
>>> single chunk. The changes are:
>>>  - Reorganized configuration: I/O drivers can be independently
>>>    configured as module or built-in
>>>  - Dynamic reconfiguration for KGDB_8250 (just like for KGDBOC)
>>>  - Reworked KGDB_8250 configuration string format
>>>  - attachwait removed, arming the debugger via assigning an I/O driver
>>>    implies "attachwait"
>>>  - Cleaned up I/O driver managment of the core
>>>  - Matured the various boot-up, configure, unconfigure code paths for
>>>    both I/O drivers
>>>  - IRQ vs. KGDB_CONSOLE-output SMP race fixed for KGDB_8250
>>>  - Reduced and cleaned up hooks into serial_core/8250
>>>  - Kconfig cleanups
>> great stuff! I've picked these cleanups up into x86.git. (will pick up 
>> Jason's commits too)
>> Could you try something else too perhaps, which would be way useful for 
>> me: to add a sysctl flag (or something like that) to change kgdboc to 
>> accept a Ctrl-C and break into kgdb mode? [this means a simple Ctrl-C on 
>> a kgdboc line would break into KGDB as well - but that would be an 
>> acceptable price.] Right now kgdboc just hangs when gdb attaches - i 
>> have to generate a SysRq sequence via a terminal emulator to break it 
>> into KGDB mode.
> FYI, even if you were to hack in a control-c vs sysrq, gdb will still

And quite a bit of "hacking" would be required here, because the sysrq
hook is built upon the assumption that a hardware break starts the
sequence, not that just a single special character comes in. Changing
this means changing the drivers, not just some central hook function.

> hang on connect because it does not issue a break of any kind when it
> connects.  It assumes the connection is in a usable state.
> The proxy spliter automatically sends the break (or in the current case
> the sysrq g)
>> This would make kgdboc way more practical without having to resort to a 
>> protocol splitting proxy, etc.
>> 	Ingo
> Jason.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

  reply	other threads:[~2008-02-07  7:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 23:34 Jan Kiszka
2008-02-05 23:44 ` Maxim Levitsky
2008-02-06  4:40 ` Jason Wessel
2008-02-07  0:13 ` Ingo Molnar
2008-02-07  0:31   ` Jason Wessel
2008-02-07  7:47     ` Jan Kiszka [this message]
2008-02-07 12:13     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/3] KGDB: Major refactoring' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).