LKML Archive on
help / color / mirror / Atom feed
From: Chuck Ebbert <>
To: Roland McGrath <>
Cc: Ingo Molnar <>, Thomas Gleixner <>,,
	Glauber de Oliveira Costa <>
Subject: Re: [PATCH] x86_64: make traps on 'iret' be debuggable in user	space
Date: Thu, 07 Feb 2008 18:28:22 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20080207203032.5BF392701AB@magilla.localdomain>

On 02/07/2008 03:30 PM, Roland McGrath wrote:
>> Did you test without CONFIG_PARAVIRT, and CONFIG_PARAVIRT booted both with and
>> without the "noreplace-paravirt" parameter?
> I did not test CONFIG_PARAVIRT at all.  I just fixed what its introduction
> had done to break generic x86-64.

It looks you may have broken paravirt (if even that case worked) because
the iret is actually at the iret_label you removed (after the instruction
is patched.) And most likely neither version worked with "noreplace-paravirt',
because then the iret instruction is out-of-line and the INTERRUPT_RETURN
jumps to it.

  reply	other threads:[~2008-02-07 23:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05  7:51 Roland McGrath
2008-02-05  8:01 ` Ingo Molnar
2008-02-05  8:15   ` Roland McGrath
2008-02-05  8:16     ` Roland McGrath
2008-02-07 20:13     ` Chuck Ebbert
2008-02-07 20:30       ` Roland McGrath
2008-02-07 23:28         ` Chuck Ebbert [this message]
2008-02-08  0:00           ` Roland McGrath
2008-02-08  0:06             ` Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] x86_64: make traps on '\''iret'\'' be debuggable in user	space' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).