LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 1/1] mxser: convert large macros to functions
Date: Fri, 08 Feb 2008 22:59:25 +0100	[thread overview]
Message-ID: <47ACD0BD.9070609@gmail.com> (raw)
In-Reply-To: <20080208134115.9289b7c7.akpm@linux-foundation.org>

On 02/08/2008 10:41 PM, Andrew Morton wrote:
> On Fri,  8 Feb 2008 10:16:48 +0100
> Jiri Slaby <jirislaby@gmail.com> wrote:
> 
>> From: Christoph Hellwig <hch@lst.de>
>>
>> From: Christoph Hellwig <hch@lst.de>
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> Acked-by: Jiri Slaby <jirislaby@gmail.com>
> 
> This should have been Signed-off-by: - you were in the delivery path.
> 
> I'll make that change.
> 
>> --- a/drivers/char/mxser.c
>> +++ b/drivers/char/mxser.c
> 
> Has this been runtime tested?

Not by me, only compiled, sparsed, checkpatched and reviewed on my side (hence 
the ack).

>> -	DISABLE_MOXA_MUST_ENCHANCE_MODE(io);
>> +	mxser_disable_must_enchance_mode(io);
> 
> hm, what's all this "enchance" stuff throughout the driver?  Did it mean
> "enhance"?

I have no idea. It seems so.

      reply	other threads:[~2008-02-08 22:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08  9:16 Jiri Slaby
2008-02-08 21:41 ` Andrew Morton
2008-02-08 21:59   ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47ACD0BD.9070609@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/1] mxser: convert large macros to functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).