LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarod Wilson <jwilson@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] firewire: fw-sbp2: add INQUIRY delay workaround
Date: Mon, 11 Feb 2008 12:01:40 -0500 [thread overview]
Message-ID: <47B07F74.6010801@redhat.com> (raw)
In-Reply-To: <tkrat.b8a4817b51d0c9c9@s5r6.in-berlin.de>
Stefan Richter wrote:
> Several different SBP-2 bridges accept a login early while the IDE
> device is still powering up. They are therefore unable to respond to
> SCSI INQUIRY immediately, and the SCSI core has to retry the INQUIRY.
> One of these retries is typically successful, and all is well.
>
> But in case of Momobay FX-3A, the INQUIRY retries tend to fail entirely.
> This can usually be avoided by waiting a little while after login before
> letting the SCSI core send the INQUIRY. The old sbp2 driver handles
> this more gracefully for as yet unknown reasons (perhaps because it
> waits for fetch agent resets to complete, unlike fw-sbp2 which quickly
> proceeds after requesting the agent reset). Therefore the workaround is
> not as much necessary for sbp2.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Looks reasonable to me. I'm guessing there are some other devices out
there that may well benefit from this (once added to the workarounds
table, of course). Interesting that this is an encore appearance for a
DViCO Momobay device...
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
--
Jarod Wilson
jwilson@redhat.com
next prev parent reply other threads:[~2008-02-11 17:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 22:00 [PATCH 0/9] firewire-sbp2: misc hotplug related patches Stefan Richter
2008-02-03 22:03 ` [PATCH 1/9] firewire: log GUID of new devices Stefan Richter
2008-02-04 8:14 ` Stefan Richter
2008-02-11 16:53 ` Jarod Wilson
2008-02-03 22:04 ` [PATCH 2/9] firewire: fw-sbp2: add INQUIRY delay workaround Stefan Richter
2008-02-11 17:01 ` Jarod Wilson [this message]
2008-02-03 22:07 ` [PATCH 3/9] ieee1394: sbp2: " Stefan Richter
2008-02-11 17:03 ` Jarod Wilson
2008-02-03 22:08 ` [PATCH 4/9] firewire: fw-sbp2: wait for completion of fetch agent reset Stefan Richter
2008-02-04 8:11 ` Stefan Richter
2008-02-03 22:09 ` [PATCH 5/9] firewire: fw-sbp2: log bus_id at management request failures Stefan Richter
2008-02-11 17:16 ` Jarod Wilson
2008-02-03 22:10 ` [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice Stefan Richter
2008-02-11 17:19 ` Jarod Wilson
2008-02-11 19:42 ` Stefan Richter
2008-02-12 8:55 ` Stefan Richter
2008-02-03 22:11 ` [PATCH 7/9] firewire: fw-sbp2: logout and login after failed reconnect Stefan Richter
2008-02-11 17:32 ` Jarod Wilson
2008-02-03 22:12 ` [PATCH 8/9] firewire: fw-sbp2: sort includes Stefan Richter
2008-02-03 22:13 ` [PATCH 9/9] firewire: fw-sbp2: fix I/O errors during reconnect Stefan Richter
2008-02-11 18:09 ` Jarod Wilson
2008-02-11 20:21 ` Stefan Richter
2008-02-12 5:07 ` Jarod Wilson
2008-02-12 8:01 ` Stefan Richter
2008-02-16 15:37 ` Stefan Richter
2008-02-16 15:51 ` Stefan Richter
2008-02-04 15:54 ` [PATCH 0/9] firewire-sbp2: misc hotplug related patches John Stoffel
2008-02-04 17:48 ` Stefan Richter
2008-02-04 18:51 ` John Stoffel
2008-02-06 5:17 ` Jarod Wilson
2008-02-06 18:27 ` Stefan Richter
2008-02-06 21:09 ` [PATCH 11/9] firewire: fw-sbp2: enforce a retry of __scsi_add_device if bus generation changed Stefan Richter
2008-02-08 18:54 ` Jarod Wilson
2008-02-08 19:58 ` Stefan Richter
2008-02-08 21:33 ` [PATCH 11/9 update] " Stefan Richter
2008-02-10 18:36 ` Jarod Wilson
2008-02-16 15:01 ` Stefan Richter
2008-02-06 21:07 ` [PATCH 10/9] firewire: fw-sbp2: preemptively block sdev Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B07F74.6010801@redhat.com \
--to=jwilson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
--subject='Re: [PATCH 2/9] firewire: fw-sbp2: add INQUIRY delay workaround' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).