LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Eric Piel <E.A.B.Piel@tudelft.nl>
To: "Carlos R. Mafra" <crmafra@gmail.com>
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [2.6.25-rc1] Strange regression with CONFIG_HZ_300=y
Date: Tue, 12 Feb 2008 09:26:28 +0100	[thread overview]
Message-ID: <47B15834.6010704@tudelft.nl> (raw)
In-Reply-To: <47B0509E.1040100@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2618 bytes --]

Carlos R. Mafra wrote:
> I apologize in advance if I am crazy about this, but I noticed
> a strange regression wrt 2.6.24 in cpufreq (I think) in 2.6.25-rc1, which
> goes away if I revert the following commit:
> 
> commit bdc807871d58285737d50dc6163d0feb72cb0dc2
> Author: H. Peter Anvin <hpa@zytor.com>
> Date:   Fri Feb 8 04:21:26 2008 -0800
> 
>     avoid overflows in kernel/time.c
> 
>     When the conversion factor between jiffies and milli- or microseconds is
>     not a single multiply or divide, as for the case of HZ == 300, we currently
>     do a multiply followed by a divide.  The intervening result, however, is
>     subject to overflows, especially since the fraction is not simplified (for
>     HZ == 300, we multiply by 300 and divide by 1000).
> 
>     This is exposed to the user when passing a large timeout to poll(), for
>     example.
> 
>     This patch replaces the multiply-divide with a reciprocal multiplication on
>     32-bit platforms.  When the input is an unsigned long, there is no portable
>     way to do this on 64-bit platforms there is no portable way to do this
>     since it requires a 128-bit intermediate result (which gcc does support on
>     64-bit platforms but may generate libgcc calls, e.g.  on 64-bit s390), but
>     since the output is a 32-bit integer in the cases affected, just simplify
>     the multiply-divide (*3/10 instead of *300/1000).
> 
>     The reciprocal multiply used can have off-by-one errors in the upper half
>     of the valid output range.  This could be avoided at the expense of having
>     to deal with a potential 65-bit intermediate result.  Since the intent is
>     to avoid overflow problems and most of the other time conversions are only
>     semiexact, the off-by-one errors were considered an acceptable tradeoff.
> 
> [...]
> [more text follows]
> 
> The problem in vanilla 2.6.25-rc1 happens with CONFIG_HZ_300=y (and doesn't
> with CONFIG_HZ_250=y or with the above commit reverted). The cpu frequency doesn't
> change anymore regardless of the load, and it stays high (2.0 GHz or 1.2 GHz) even
> when idle (I checked with 'top'), when the usual is to go to 800 Mhz when idle (I
> always use the ondemand governor compiled in and as the default governor).
> 
> The laptop is a Vaio VGN-FZ240E, core 2 duo T7250 @ 2.0 GHz and the kernel is x86_64.

Hi, it's great you found out the culprit commit because I was really 
wondering where this bug was coming from...
As a data point, my machine has a core 2 duo @ 1.2GHz and x86_64 arch. 
Do you also have the tickless option activated? (it could play a role)

See you,
Eric

[-- Attachment #2: E_A_B_Piel.vcf --]
[-- Type: text/x-vcard, Size: 342 bytes --]

begin:vcard
fn;quoted-printable:=C3=89ric Piel
n;quoted-printable:Piel;=C3=89ric
org:Technical University of Delft;Software Engineering Research Group
adr:HB 08.080;;Mekelweg 4;Delft;;2628 CD;The Netherlands
email;internet:E.A.B.Piel@tudelft.nl
tel;work:+31 15 278 6338
x-mozilla-html:FALSE
url:http://pieleric.free.fr
version:2.1
end:vcard


  reply	other threads:[~2008-02-12  8:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 13:41 Carlos R. Mafra
2008-02-12  8:26 ` Eric Piel [this message]
2008-02-12 11:41   ` Carlos R. Mafra
2008-02-12 19:23   ` H. Peter Anvin
2008-02-12 19:53     ` Carlos R. Mafra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B15834.6010704@tudelft.nl \
    --to=e.a.b.piel@tudelft.nl \
    --cc=crmafra@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [2.6.25-rc1] Strange regression with CONFIG_HZ_300=y' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).