LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@yandex.ru>
To: caglar@pardus.org.tr
Cc: Jiri Slaby <jirislaby@gmail.com>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)
Date: Tue, 12 Feb 2008 11:33:30 +0200	[thread overview]
Message-ID: <47B167EA.1070402@yandex.ru> (raw)
In-Reply-To: <200802110144.07549.caglar@pardus.org.tr>

S.Çağlar Onur wrote:
> Hi;
> 
> 10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: 
>> I think this is not correct. You change the err which caused the failure. You 
>> change it even to 0 if it doesn't fail and the whole function will seem like 
>> non-failing.
> 
> My bad, sorry for not looking carefully. Assuming a refactoring is not desired for just a compiler warning, is following acceptable (this kind of plain messages seems heavily used in vmt.c, so i'm again assuming its OK to use such style)?
> 
> commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images) introduced the warning
> 
> drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
> drivers/mtd/ubi/vmt.c:379: warning: statement with no effect
> 
> 
>  drivers/mtd/ubi/vmt.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 

Thanks, applied to UBI git with Minor changes, will send git-pull request
shortly.

Please, note that my e-mail address is not dedekind@linutronix.de,
see MAINTAINERS.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

      reply	other threads:[~2008-02-12  9:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10  3:37 S.Çağlar Onur
2008-02-10  8:39 ` Jiri Slaby
2008-02-10 23:44   ` S.Çağlar Onur
2008-02-12  9:33     ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B167EA.1070402@yandex.ru \
    --to=dedekind@yandex.ru \
    --cc=caglar@pardus.org.tr \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).