LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] timeconst.pl: correct reversal of USEC_TO_HZ and HZ_TO_USEC
@ 2008-02-12 21:52 H. Peter Anvin
  2008-02-12 22:25 ` Carlos R. Mafra
  0 siblings, 1 reply; 2+ messages in thread
From: H. Peter Anvin @ 2008-02-12 21:52 UTC (permalink / raw)
  To: Linus Torvalds, Linux Kernel Mailing List; +Cc: Eric Piel, Carlos R. Mafra

The USEC_TO_HZ and HZ_TO_USEC constant sets were mislabelled, with
seriously incorrect results.  This among other things manifested
itself as cpufreq not working when a tickless kernel was configured.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 kernel/timeconst.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/timeconst.pl b/kernel/timeconst.pl
index 62b1287..4146803 100644
--- a/kernel/timeconst.pl
+++ b/kernel/timeconst.pl
@@ -339,7 +339,7 @@ sub output($@)
 	print "\n";
 
 	foreach $pfx ('HZ_TO_MSEC','MSEC_TO_HZ',
-		      'USEC_TO_HZ','HZ_TO_USEC') {
+		      'HZ_TO_USEC','USEC_TO_HZ') {
 		foreach $bit (32, 64) {
 			foreach $suf ('MUL', 'ADJ', 'SHR') {
 				printf "#define %-23s %s\n",
-- 
1.5.3.8


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] timeconst.pl: correct reversal of USEC_TO_HZ and HZ_TO_USEC
  2008-02-12 21:52 [PATCH] timeconst.pl: correct reversal of USEC_TO_HZ and HZ_TO_USEC H. Peter Anvin
@ 2008-02-12 22:25 ` Carlos R. Mafra
  0 siblings, 0 replies; 2+ messages in thread
From: Carlos R. Mafra @ 2008-02-12 22:25 UTC (permalink / raw)
  To: H. Peter Anvin; +Cc: Linus Torvalds, Linux Kernel Mailing List, Eric Piel

H. Peter Anvin wrote:
> The USEC_TO_HZ and HZ_TO_USEC constant sets were mislabelled, with
> seriously incorrect results.  This among other things manifested
> itself as cpufreq not working when a tickless kernel was configured.
> 
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>


Tested-by: Carlos R. Mafra <crmafra@ift.unesp.br>


> ---
>  kernel/timeconst.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/timeconst.pl b/kernel/timeconst.pl
> index 62b1287..4146803 100644
> --- a/kernel/timeconst.pl
> +++ b/kernel/timeconst.pl
> @@ -339,7 +339,7 @@ sub output($@)
>  	print "\n";
>  
>  	foreach $pfx ('HZ_TO_MSEC','MSEC_TO_HZ',
> -		      'USEC_TO_HZ','HZ_TO_USEC') {
> +		      'HZ_TO_USEC','USEC_TO_HZ') {
>  		foreach $bit (32, 64) {
>  			foreach $suf ('MUL', 'ADJ', 'SHR') {
>  				printf "#define %-23s %s\n",


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-12 22:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-12 21:52 [PATCH] timeconst.pl: correct reversal of USEC_TO_HZ and HZ_TO_USEC H. Peter Anvin
2008-02-12 22:25 ` Carlos R. Mafra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).