LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Sergio Luis <sergio@larces.uece.br>,
	Achim Leubner <achim_leubner@adaptec.com>,
	linux-scsi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device
Date: Wed, 13 Feb 2008 10:57:37 +0200	[thread overview]
Message-ID: <47B2B101.3090106@panasas.com> (raw)
In-Reply-To: <1202861823.3137.170.camel@localhost.localdomain>

On Wed, Feb 13 2008 at 2:17 +0200, James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote:
>> reposting an updated version of it. Please check if it's ok.
> 
> Looks fine, thanks!  You added an extra space at the end of 
> 
> while ((pdev = pci_get_device(vendor, device, pdev)) 
> 
> Which I fixed.  Unfortunately checkpatch isn't very helpful for this
> driver since it uses spaces not tabs everywhere, which checkpatch really
> hates.
> 
> James
> 
> 
James hi
This patch is now obsolete. After Jeff's patch to convert it to 
hot plug API. Jeffs patch looks very good to me. I will try
to push it through the testers.

I still don't have a card for testing myself. Again anyone
wants to send me a card. Intel people anybody home?

I will add the missing Kconfig hunk to jeff's patch and will
push it after it is tested.

Thanks
Boaz

  reply	other threads:[~2008-02-13  8:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 14:31 Sergio Luis
2008-02-12 16:22 ` James Bottomley
2008-02-12 16:54   ` Boaz Harrosh
     [not found]     ` <47B23033.1080100@larces.uece.br>
2008-02-13  0:17       ` James Bottomley
2008-02-13  8:57         ` Boaz Harrosh [this message]
2008-02-16 16:37           ` Matthew Wilcox
2008-02-17 10:37             ` Boaz Harrosh
2008-02-17 16:42               ` Jeff Garzik
2008-03-04  7:48               ` Hannes Reinecke
2008-03-04 12:04                 ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B2B101.3090106@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=achim_leubner@adaptec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=sergio@larces.uece.br \
    --subject='Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).